Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1773] Rails input masking: credit_card and cvv #4267

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[PLAY-1773] Rails input masking: credit_card and cvv #4267

merged 1 commit into from
Feb 12, 2025

Conversation

kangaree
Copy link
Contributor

What does this PR do?

  • Continues work in PLAY-1772 and PLAY-1866. (PLAY-1773).
  • Adds credit_card and cvv mask
  • Make mask prop an enum

Screenshots:
Screenshot 2025-02-12 at 9 08 17 AM

How to test?

  1. Go to /kits/text_input/rails#mask
  2. Type in the Credit Card and CVV text inputs
  3. They should be masked as you type

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@kangaree kangaree added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Feb 12, 2025
@kangaree kangaree requested a review from a team as a code owner February 12, 2025 14:08
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Feb 12, 2025
markdoeswork
markdoeswork approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@markdoeswork markdoeswork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super duper

@kangaree kangaree added the Inactive RC Skip the release candidate process label Feb 12, 2025
@kangaree kangaree merged commit 8d9a8da into master Feb 12, 2025
17 checks passed
@kangaree kangaree deleted the PLAY-1773-rails-cc-cvv branch February 12, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdoeswork markdoeswork markdoeswork approved these changes

@nidaqg nidaqg nidaqg approved these changes

Assignees
No one assigned
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kangaree @markdoeswork @nidaqg