Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow empty saved_changes in camel_trail #307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thestephenmarshall
Copy link

Allowing camel_trail to record changes that are empty ({}) should not be possible. If no changes are present, return. This prevents useless records from being created.

@thestephenmarshall thestephenmarshall self-assigned this Feb 5, 2025
@thestephenmarshall thestephenmarshall requested a review from a team as a code owner February 5, 2025 23:13
@thestephenmarshall thestephenmarshall added the bug Something isn't working label Feb 5, 2025
xjunior
xjunior previously approved these changes Feb 6, 2025
@xjunior
Copy link
Contributor

xjunior commented Feb 6, 2025

@thestephenmarshall can you:

  1. Add an entry to CHANGELOG
  2. Bump the version in version.rb
  3. bundle and appraisal (bundle && bundle exec appraisal)

Commit these changes so when we merge this PR I can cut a release

@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=olaws-118-disallow-empty-changes

@thestephenmarshall thestephenmarshall added enhancement New feature or request and removed bug Something isn't working labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants