Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires changes to the core extension to work, hence the WIP.
This adds interfaces for tracking download progress during a sync operation. Following the design doc:
ProgressWithOperations
class provides information about how many rows have been downloaded already and how many need to be downloaded in total to complete the current sync (and uses that to provide afraction
getter).SyncDownloadProgress
class keeps track of downloaded operations for each bucket. It can compute aggregateProgressWithOperations
results for the next complete sync (across all buckets) or up until a given priority (includes all buckets with that or a higher priority).SyncDownloadProgress
is made available fromSyncStatus
.The implementation uses new columns added to
ps_buckets
tracking the operation count at the last checkpoint and the amount of downloaded operations since then:ps_buckets
and use that to populate the initial progress status.SyncDownloadProgress
instance in memory.I've also refactored some things around copying sync statutes internally (we don't have to write our own
copy
methods with special args to reset the upload + download error, optional arguments in Kotlin don't have to be constant so passingdownloadError = null
will actually reset the value).