Merged
Conversation
simolus3
approved these changes
Apr 7, 2025
Contributor
simolus3
left a comment
simolus3
left a comment
There was a problem hiding this comment.
Nice 👍 I wonder if we should just always pass NO_VERSION_CHECK given that we don't actually apply any schema. But it's good to have the fix in first, we can check refactoring this and removing InternalSchema afterwards.
Contributor
Author
Agreed. We probably could and should refactor a lot of the current SQLDelight iOS (and potentially others) driver at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We currently create multiple readonly connections via the iOS driver. The iOS driver attempts to run schema migrations whenever a driver is created. It looks like these migrations are not synchronized internally. This causes errors of the form
See example failed test
This changeset avoids attempting to run migrations on read only drivers.