Conversation
simolus3
marked this pull request as ready for review
August 3, 2026 14:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues reported in #172.
Crashes on race between
close()and other operationsEmitting a closed SQLite connection as a connection lease crashes the process (as a
precondition). This is better than the use-after-free it would have been otherwise, but it shouldn't be possible to reach that state. Unfortunately, it can happen when:close().close()did not complete yet,DatabaseInitializationAction.ensureInitialized()works and the operation can continue. It waits for a connection, though.The fix is what we do on most other SDKs too: Check for closed connections after we've obtained their handle from an async semaphore.
Cancelling
close()When a call to
close()is cancelled before it actually closes connections, it would previously leave the database in a state where everything throws even though connections are still open.This fixes the issue by only marking the database as closed when connections are actually closed. There's still a race condition here where while a database is being closed, queries would throw but if the throw is cancelled the database keeps working afterwards. I think that should be harmless overall, though.
AI use: Original issue report is likely generated by AI. Changes are manual, with minor revisions after a review with Claude Code.