Attachments Helper #35
Open
+2,587
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 32 out of 35 changed files in this pull request and generated 2 comments.
Files not reviewed (3)
- Demo/PowerSyncExample.xcodeproj/project.pbxproj: Language not supported
- Demo/PowerSyncExample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved: Language not supported
- Demo/PowerSyncExample.xcodeproj/xcshareddata/xcschemes/PowerSyncExample.xcscheme: Language not supported
There was a problem hiding this comment.
Copilot reviewed 33 out of 36 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- Demo/PowerSyncExample.xcodeproj/project.pbxproj: Language not supported
- Demo/PowerSyncExample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved: Language not supported
- Demo/PowerSyncExample.xcodeproj/xcshareddata/xcschemes/PowerSyncExample.xcscheme: Language not supported
…-swift into attachmentshelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attachments helper for Swift. The logic here is a port of powersync-ja/powersync-kotlin#159.
It should technically be possible to use the Attachments logic from the core module in the Swift SDK. However, the SKIEE conversion does not handle Swift exceptions and Flows well. There are work-arounds to mitigate this, but implementing those workarounds feels like it makes the Kotlin attachment helper unnecessarily complex. Porting the code to a pure Swift implementation gives a cleaner and simpler attachment helper which does not require glue code to Kotlin types.
DEMO
Syncing attachments between iOS and MacOS devices
SwiftAttachmentsDemo.mp4
TODOS