-
Notifications
You must be signed in to change notification settings - Fork 11
Improve connection pool read performance #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stevensJourney
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation worked as follows:
This worked okay for a small number of connections, but scaled quite badly when the number of connections is increased. Even with the default maximum of 5 read connections, the number of read locks/s benchmark is reduced from 107k/s to 36k/s on my machine when those connections have been opened. This adds significant overhead when doing many individual select statements.
This is a complete re-implementation of the logic, using a queue of pending operations and available connections instead. This ends up being simpler (less edge cases), and scales much better with the number of connections.
Builds on #37Now part of this PR:Fixes #36 (issues when closing the database while queries are still running).
Also improves handling of database initialization errors and other uncaught errors in connection isolates.