Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES extensions SerDe fixes #3145

Merged
merged 15 commits into from
Sep 23, 2024
Merged

CGMES extensions SerDe fixes #3145

merged 15 commits into from
Sep 23, 2024

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Sep 17, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No, but should solve issue powsybl/pypowsybl#830 in other repository

What kind of change does this PR introduce?
Bug fix

What is the current behavior?

  • serialization/deserialization unit tests missing on some CGMES extensions
  • roundtrips in CGMES extensions / ENTSOE extension not using binary format
  • Enum written as string (causes binary roundtrip to fail)
  • attribute read in another order than written (causes json & binary roundtrip to fail)
  • optional String attributes written using Optional::ifPresent instead of TreeDataWriter::writeOptionalString (causes binary roundtrip to fail)

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@flo-dup flo-dup requested review from geofjamg and rolnico September 17, 2024 13:14
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Copy link

@flo-dup flo-dup merged commit ddbef02 into main Sep 23, 2024
7 checks passed
@flo-dup flo-dup deleted the serde_cgmes_extensions_fix branch September 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants