Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency: created build_script for Scipy v1.11.3 #5361

Open
wants to merge 3 commits into
base: python-ecosystem
Choose a base branch
from
Open

Currency: created build_script for Scipy v1.11.3 #5361

wants to merge 3 commits into from

Conversation

kiranNukal
Copy link
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

@kiranNukal kiranNukal marked this pull request as ready for review January 28, 2025 03:38
shubham-dayma-ibm
shubham-dayma-ibm requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@shubham-dayma-ibm shubham-dayma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address comments and needs to be reviewed from Nikhil, Amir, Priya

s/scipy/scipy_v1.11.3_ubi_9.3.sh Outdated
PACKAGE_NAME=scipy
PACKAGE_VERSION=${1:-v1.11.3}
PACKAGE_URL=https://github.com/scipy/scipy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing PACKAGE_DIR

Copy link
Contributor Author

@kiranNukal kiranNukal Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham-dayma-ibm addressed.

s/scipy/scipy_v1.11.3_ubi_9.3.sh

echo "Building and installing $PACKAGE_NAME..."
# issue: https://github.com/scipy/scipy/issues/21100#issuecomment-2538514333
if [[ $PACKAGE_VERSION == "v1.11.3" ]] && [[ $(git diff pyproject.toml | wc -l) -eq 0 ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhil-kalbande is it good to add version specific conditions, in build-script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-dayma-ibm shubham-dayma-ibm shubham-dayma-ibm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiranNukal @shubham-dayma-ibm