Namespacing: Use mlk_xxx prefix for all identifiers of global scope #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
force-pushed
the
mlk_namespacing
branch
from
6fc8f02 to
bc96b5d
Compare
hanno-becker
force-pushed
the
mlk_namespacing
branch
4 times, most recently
from
777d210 to
a63c2e7
Compare
This commit changes the name of all identifiers in global scope by adding a prefix `mlk_`. For example, `check_pk` becomes `mlk_check_pk`, and the struct `poly` becomes `mlk_poly`. Excluded is the standard crypto_kem_xxx API, which stays as is. mlk_mlkem is folded to mlk, affecting e.g. mlkem_debug_... which is now mlk_debug. Signed-off-by: Hanno Becker <[email protected]>
Also, fix up some hyperlink that got eagerly renamed. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
mlk_namespacing
branch
2 times, most recently
from
a49b8b0 to
ac7f359
Compare
It seem to be pre-installed and sufficiently recent on all Mac system we test on, and the upgrade to a newer version triggered by `brew install python3` can sometimes fail. Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
mlk_namespacing
branch
from
ac7f359 to
eb8faf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the name of all identifiers in global scope by adding a prefix
mlk_. For example,check_pkbecomesmlk_check_pk, and the structpolybecomesmlk_poly.Excluded is the standard crypto_kem_xxx API, which stays as is.