Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrebidMobile-core: ExternalUserId must serialize atype as atype not adtype. #821

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

alightr
Copy link
Contributor

@alightr alightr commented Jan 17, 2025

UID.adtype does not exist as a property. This is a typo and is causing issues for us. See [1] for more information.

Fixes #798.

[1] https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md#3228---object-uid-

@YuriyVelichkoPI
Copy link
Contributor

Partially fixes: #802

Copy link
Contributor

@Valllent Valllent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@ValentinPostindustria ValentinPostindustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriyVelichkoPI YuriyVelichkoPI merged commit 1888bc1 into prebid:master Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Json conversion in ExternalUserId class for Android differs from IOS'
4 participants