Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Adt - Admatic alias #4183

Merged
merged 71 commits into from
Feb 12, 2025
Merged

Conversation

bakicam
Copy link
Contributor

@bakicam bakicam commented Jan 29, 2025

@farukcam
Copy link
Contributor

Hello @bsardo,
I would like to ask for your support for our new adapter. Have a nice day.

@bsardo bsardo added the adapter label Jan 29, 2025
@bsardo bsardo changed the title Admatic: add alias Adt New Adapter: Adt - Admatic alias Feb 5, 2025
@farukcam
Copy link
Contributor

farukcam commented Feb 7, 2025

Hello @bsardo,
When can you release this adapter? We want to plan accordingly. Have a nice day.

static/bidder-info/adt.yml Outdated Show resolved Hide resolved
static/bidder-info/adt.yml Outdated Show resolved Hide resolved
static/bidder-info/adt.yml Outdated Show resolved Hide resolved
@bsardo bsardo self-assigned this Feb 10, 2025
@bsardo bsardo assigned guscarreon and SyntaxNode and unassigned guscarreon Feb 11, 2025
@SyntaxNode
Copy link
Contributor

@bakicam Please open a new docs PR to update adt.md to include the Prebid Server parameters to align with https://github.com/prebid/prebid-server/blob/master/static/bidder-params/adtarget.json.

This includes:
aid - required
placementId - optional
siteId - optional
bidFloor - optional

@farukcam
Copy link
Contributor

Hi @SyntaxNode and @bsardo,
I hope you are well.
I think there is a misunderstanding. Adtarget and Adt are different adapters. The parameters specified on adt.md are valid and correct for the adt adapter.

@SyntaxNode
Copy link
Contributor

I see. Yes, I was comparing against adtarget instead of admatic. This is because this alias uses an adtarget support email and the adtarget gvl vendor id.

What's the relationship between adtarget and admatic?

@farukcam
Copy link
Contributor

Admatic provides technology for adtarget. The fact that gvlid and mail are the same is due to the new adapter of the adtarget brand. However, the old adapter may continue to work.

@SyntaxNode SyntaxNode merged commit 2b23016 into prebid:master Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants