fix: input globs normalisation and force reinstall #4931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichmor
commented
Nov 17, 2025
| // If a simple rename fails (e.g., across filesystems), fall back to copy+remove. | ||
| if let Err(_e) = fs_err::rename(&package_path, &dest_path) { | ||
| fs_err::copy(&package_path, &dest_path).into_diagnostic()?; | ||
| fs_err::remove_file(&package_path).into_diagnostic()?; |
Contributor
Author
There was a problem hiding this comment.
We don't need to remove cached artefact
ruben-arts
reviewed
Nov 17, 2025
Contributor
ruben-arts
left a comment
ruben-arts
left a comment
There was a problem hiding this comment.
I didn't test it yet but, could you take a look at the tests? The error seems related.
|
|
||
|
|
||
| @pytest.mark.slow | ||
| def test_install_source_package_with_force_reinstall( |
Contributor
There was a problem hiding this comment.
Can you reduce the impact of this test on our CI time, this is taking 16s where only one test is slower than that.
Some ideas would be a really basic python package
Contributor
Author
There was a problem hiding this comment.
only by moving this test to the pixi-integration-tests repo
baszalmstra
reviewed
Nov 21, 2025
|
|
||
|
|
||
| @pytest.mark.slow | ||
| def test_install_source_package_with_force_reinstall( |
Contributor
There was a problem hiding this comment.
Maybe we can make this test use the in-memory backend instead of actually installing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains two fixes inside (and one improvement)
recipe/..which would be ignored. Instead, they should be normalized as "" ( current dir ) for which we will use ** glob.--force-reinstallnow indeed triggers entire source rebuild.pixi build( which will bypass using cache ), we now cache the result of a build. This was discovered when testing the global installFixes #4844
How Has This Been Tested?
Checklist: