fix: skip system CA store for pypi mapping middleware client - #6936
Open
r3wretrhy wants to merge 1 commit into
Open
fix: skip system CA store for pypi mapping middleware client#6936r3wretrhy wants to merge 1 commit into
r3wretrhy wants to merge 1 commit into
Conversation
The mapping cache stack needs a dummy reqwest client because the cache must sit outside the caller's offline middleware. Client::new() still loads system roots and panics on hosts without a CA store, even when tls-root-certs = webpki. Also list tls-root-certs in pixi config list so the setting is inspectable. Fixes prefix-dev#6825.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mapping cache middleware builds a dummy reqwest client so the cache can sit outside the caller's offline stack.
Client::new()still initializes system CAs, which panics whentls-root-certs = webpkion a host without a conventional CA store.Use
tls_certs_only([])for that unused inner client. Also listtls-root-certsinpixi config list.Fixes #6825.
How Has This Been Tested?