refactor(pixi-build-cmake): name the build directory once - #6937
Open
hunger wants to merge 1 commit into
Open
Conversation
The build script created and entered `build` by writing the name out, next to a template variable holding the same name and the NINJA_BUILD_DIR constant that the input tracking uses to find the tree again afterwards. Three spellings of one name, and the two in the template were already out of step: the Windows branch used the variable, while the Unix branch and the shared `pushd` did not. Nothing misbehaves today, as all three say `build`. Changing one of them is what breaks: the input tracking would go looking for a tree the script no longer creates, and no test would notice. The constant is now the single definition and reaches the template through the context, the way the source directory already does. The rendered scripts are unchanged.
Contributor
Author
|
@Hofer-Julian This one is small and should be uncontroversial. The next one adds a parser for cmake, that is going to be bigger (and more error prone). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build script created and entered
buildby writing the name out, next to a template variable holding the same name and the NINJA_BUILD_DIR constant that the input tracking uses to find the tree again afterwards. Three spellings of one name, and the two in the template were already out of step: the Windows branch used the variable, while the Unix branch and the sharedpushddid not.Nothing misbehaves today, as all three say
build. Changing one of them is what breaks: the input tracking would go looking for a tree the script no longer creates, and no test would notice.The constant is now the single definition and reaches the template through the context, the way the source directory already does. The rendered scripts are unchanged.
AI Disclosure
Tools: Claude, Codex
Checklist:
schema/model.py.