fix: run link checks when relocation is disabled - #2787
Open
rootsec1 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
binary_relocation: falsecurrently returns from post-processing before dynamic binaries are discovered, so it also disables requested overlinking and overdepending checks. The same coupling prevents those checks from running on Windows, where relocation itself is intentionally skipped.This change discovers every supported binary independently of the relocation selection. Relinking still happens only for paths selected by
binary_relocation, and never on Windows; the complete discovered set is then passed to the existing linking checks. NoArch and WASM exclusions are unchanged.Regression coverage exercises an undeclared zlib link with relocation disabled on Linux and Windows, plus a declared-dependency Linux build that records the pre-processing binary hash and verifies the packaged binary is byte-identical.
Verified locally with:
pixi run test-end-to-end-ci(220 passed, 18 skipped)pixi run cargo test --workspace --all-targets --features=recipe-generation -- --nocapturepixi run -e pre-commit lintpixi run cargo fmt --all -- --checkpixi run cargo clippy --workspace --all-targets --features=recipe-generation -- -D warningsCloses #2771