Skip to content

fix: run link checks when relocation is disabled - #2787

Open
rootsec1 wants to merge 3 commits into
prefix-dev:mainfrom
rootsec1:fix/link-checks-without-relocation
Open

fix: run link checks when relocation is disabled#2787
rootsec1 wants to merge 3 commits into
prefix-dev:mainfrom
rootsec1:fix/link-checks-without-relocation

Conversation

@rootsec1

@rootsec1 rootsec1 commented Aug 31, 2026

Copy link
Copy Markdown

binary_relocation: false currently returns from post-processing before dynamic binaries are discovered, so it also disables requested overlinking and overdepending checks. The same coupling prevents those checks from running on Windows, where relocation itself is intentionally skipped.

This change discovers every supported binary independently of the relocation selection. Relinking still happens only for paths selected by binary_relocation, and never on Windows; the complete discovered set is then passed to the existing linking checks. NoArch and WASM exclusions are unchanged.

Regression coverage exercises an undeclared zlib link with relocation disabled on Linux and Windows, plus a declared-dependency Linux build that records the pre-processing binary hash and verifies the packaged binary is byte-identical.

Verified locally with:

  • pixi run test-end-to-end-ci (220 passed, 18 skipped)
  • pixi run cargo test --workspace --all-targets --features=recipe-generation -- --nocapture
  • pixi run -e pre-commit lint
  • pixi run cargo fmt --all -- --check
  • pixi run cargo clippy --workspace --all-targets --features=recipe-generation -- -D warnings

Closes #2771

@rootsec1 rootsec1 closed this Aug 31, 2026
@rootsec1 rootsec1 reopened this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting binary_relocation: false disables link checking

1 participant