Skip to content

Lines in file are displayed in NERDTree. #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hsnks100
Copy link
Contributor

@hsnks100 hsnks100 commented Sep 15, 2022

Description of Changes

Closes #


New Version Info

Author's Instructions

  • Derive a new MAJOR.MINOR.PATCH version number. Increment the:
    • MAJOR version when you make incompatible API changes
    • MINOR version when you add functionality in a backwards-compatible manner
    • PATCH version when you make backwards-compatible bug fixes
  • Update CHANGELOG.md, following the established pattern.

Collaborator's Instructions

  • Review CHANGELOG.md, suggesting a different version number if necessary.
  • After merging, tag the commit using these (Mac-compatible) bash commands:
    git checkout master
    git pull
    sed -n "$(grep -n -m2 '####' CHANGELOG.md | cut -f1 -d: | sed 'N;s/\n/,/')p" CHANGELOG.md | sed '$d'
    git tag -a $(read -p "Tag Name: " tag;echo $tag) -m"$(git show --quiet --pretty=%s)";git push origin --tags

This function shown as below:
image

@rzvxa
Copy link
Member

rzvxa commented Oct 22, 2023

Hello @hsnks100 sorry for pinging you on this old PR, sadly when you created this NERDTree had no maintainer and that's why it took this long until you got a reply on it.
By any chance do you still have interest in doing this feature? I can see the value in it but I would like to propose a few changes before merging it. In case you don't want to work on it I'll make sure that you get credits of the initial code.

@rzvxa rzvxa mentioned this pull request Oct 25, 2023
@rzvxa
Copy link
Member

rzvxa commented Nov 15, 2023

Hi, @hsnks100 Thanks to your contribution this feature has been added to the newest version of NEDRTree via #1384 PR(which you've got the credit for it).
Because of that, I'm going to close this merge request.

@rzvxa rzvxa closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants