Remove some vestigial warning suppressions that are no longer needed

prestodb · Jun 4, 2024 · 1b491ba · 1b491ba
1 parent 36d289d
commit 1b491ba
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 11 deletions.
diff --git a/presto-hive/src/test/java/com/facebook/presto/hive/AbstractTestHiveClient.java b/presto-hive/src/test/java/com/facebook/presto/hive/AbstractTestHiveClient.java
@@ -1668,7 +1668,6 @@ public void testGetPartitionNamesException()
         }
     }
 
-    @SuppressWarnings({"ValueOfIncrementOrDecrementUsed", "UnusedAssignment"})
     @Test
     public void testGetTableSchemaPartitionFormat()
     {
@@ -2066,7 +2065,6 @@ public void testBucketedTableStringInt()
         }
     }
 
-    @SuppressWarnings("ConstantConditions")
     @Test
     public void testBucketedTableBigintBoolean()
             throws Exception

diff --git a/presto-hive/src/test/java/com/facebook/presto/hive/util/TestSerDeUtils.java b/presto-hive/src/test/java/com/facebook/presto/hive/util/TestSerDeUtils.java
@@ -64,7 +64,6 @@
 import static org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorFactory.getReflectionObjectInspector;
 import static org.testng.Assert.assertEquals;
 
-@SuppressWarnings("PackageVisibleField")
 public class TestSerDeUtils
 {
     private final BlockEncodingSerde blockEncodingSerde = new BlockEncodingManager();

diff --git a/presto-main/src/test/java/com/facebook/presto/execution/buffer/TestClientBuffer.java b/presto-main/src/test/java/com/facebook/presto/execution/buffer/TestClientBuffer.java
@@ -474,7 +474,6 @@ private static BufferResult bufferResult(long token, Page firstPage, Page... oth
         return createBufferResult(TASK_INSTANCE_ID, token, pages);
     }
 
-    @SuppressWarnings("ConstantConditions")
     private static void assertBufferDestroyed(ClientBuffer buffer, int pagesSent)
     {
         BufferInfo bufferInfo = buffer.getInfo();

diff --git a/...va/com/facebook/presto/operator/aggregation/groupByAggregations/AggregationTestInput.java b/...va/com/facebook/presto/operator/aggregation/groupByAggregations/AggregationTestInput.java
@@ -37,7 +37,6 @@ public class AggregationTestInput
     private final int offset;
     private final boolean isReversed;
 
-    @SuppressWarnings("NumericCastThatLosesPrecision")
     public AggregationTestInput(JavaAggregationFunctionImplementation function, Page[] pages, int offset, boolean isReversed)
     {
         this.pages = pages;

diff --git a/presto-main/src/test/java/com/facebook/presto/operator/scalar/BenchmarkArrayJoin.java b/presto-main/src/test/java/com/facebook/presto/operator/scalar/BenchmarkArrayJoin.java
@@ -80,7 +80,6 @@ public List<Optional<Page>> benchmark(BenchmarkData data)
                         data.getPage()));
     }
 
-    @SuppressWarnings("FieldMayBeFinal")
     @State(Scope.Thread)
     public static class BenchmarkData
     {

diff --git a/presto-main/src/test/java/com/facebook/presto/operator/scalar/BenchmarkArrayTransform.java b/presto-main/src/test/java/com/facebook/presto/operator/scalar/BenchmarkArrayTransform.java
@@ -95,7 +95,6 @@ public Object benchmark(BenchmarkData data)
                         data.getPage()));
     }
 
-    @SuppressWarnings("FieldMayBeFinal")
     @State(Scope.Thread)
     public static class BenchmarkData
     {

diff --git a/presto-main/src/test/java/com/facebook/presto/server/TestServer.java b/presto-main/src/test/java/com/facebook/presto/server/TestServer.java
@@ -105,7 +105,6 @@ public void setup()
         client = new JettyHttpClient();
     }
 
-    @SuppressWarnings("deprecation")
     @AfterMethod
     public void teardown()
     {

diff --git a/presto-orc/src/test/java/com/facebook/presto/orc/AbstractTestOrcReader.java b/presto-orc/src/test/java/com/facebook/presto/orc/AbstractTestOrcReader.java
@@ -259,7 +259,7 @@ private static TempFile createTempFile(int nRecords)
         TempFile file = new TempFile();
         RecordWriter writer = createOrcRecordWriter(file.getFile(), ORC_12, CompressionKind.NONE, BIGINT);
 
-        @SuppressWarnings("deprecation") Serializer serde = new OrcSerde();
+        Serializer serde = new OrcSerde();
         SettableStructObjectInspector objectInspector = createSettableStructObjectInspector("test", BIGINT);
         Object row = objectInspector.create();
         StructField field = objectInspector.getAllStructFieldRefs().get(0);

diff --git a/presto-redis/src/main/java/com/facebook/presto/redis/RedisMetadata.java b/presto-redis/src/main/java/com/facebook/presto/redis/RedisMetadata.java
@@ -243,7 +243,6 @@ Map<SchemaTableName, RedisTableDescription> getDefinedTables()
         return redisTableDescriptionSupplier.get();
     }
 
-    @SuppressWarnings("ValueOfIncrementOrDecrementUsed")
     private ConnectorTableMetadata getTableMetadata(SchemaTableName schemaTableName)
     {
         RedisTableDescription table = getDefinedTables().get(schemaTableName);

diff --git a/presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestWindowQueries.java b/presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestWindowQueries.java
@@ -254,7 +254,6 @@ public void testWindowFunctionWithImplicitCoercion()
         assertQuery("SELECT *, 1.0 * sum(x) OVER () FROM (VALUES 1) t(x)", "SELECT 1, 1.0");
     }
 
-    @SuppressWarnings("PointlessArithmeticExpression")
     @Test
     public void testWindowFunctionsExpressions()
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -254,7 +254,6 @@ public void testWindowFunctionWithImplicitCoercion() @@
             assertQuery("SELECT *, 1.0 * sum(x) OVER () FROM (VALUES 1) t(x)", "SELECT 1, 1.0");
         }
-        @SuppressWarnings("PointlessArithmeticExpression")
         @Test
         public void testWindowFunctionsExpressions()
         {
@@ Expand Down @@