Fix for select query failure in presto-bigquery

[nishithakbhaskaran]

Description

Fix for select query failure in presto-bigquery

Motivation and Context

#23951

Impact

Test Plan

Tested the fix and the select query works fine.

Contributor checklist

• Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==
BigQuery Connector Changes
* Fix for BigQuery ``SELECT``. :pr:`23957`

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: nishithakbhaskaran (dca4893)

[imjalpreet]

For context, can you please share the dependency tree before and after this change?

Also, to confirm, the only class that was causing the issue was CallCredentials2?

[nishithakbhaskaran]

@imjalpreet Please see the dependency tree before and after the fix
dependencies-after.txt
dependencies-before.txt

Presto <grpc.version>1.64.0</grpc.version> was updated. The issue was java.lang.NoClassDefFoundError: io/grpc/CallCredentials2 as CallCredentials2.java was removed from the grpc-api:1.64.0 version.

In presto-bigquery below grpc dependencies are of an older version.So we tried updating them as well to 1.64.0
io.grpc:grpc-auth:jar:1.64.0:compile
io.grpc:grpc-alts:jar:1.64.0:compile
io.grpc:grpc-grpclb:jar:1.64.0:compile

[steveburnett]

Suggest revising the release note entry as follows:

== RELEASE NOTES ==
BigQuery Connector Changes
* Fix for BigQuery ``SELECT``. :pr:`23957`

[nishithakbhaskaran]

@steveburnett Updated the release note entry as suggested.

[imjalpreet]

Presto <grpc.version>1.64.0</grpc.version> was updated. The issue was java.lang.NoClassDefFoundError: io/grpc/CallCredentials2 as CallCredentials2.java was removed from the grpc-api:1.64.0 version.

Yes, it was removed after ~ 1.41.x.

In presto-bigquery below grpc dependencies are of an older version.So we tried updating them as well to 1.64.0

Yes thanks, just wanted to confirm the same from the dependency tree.

[imjalpreet]

Is this a new transitive dependency due to the version upgrade? Is it also included in Presto as part of any other dependency?

[nishithakbhaskaran]

@imjalpreet Added those exclusion to resolve Require upper bound dependencies error in bigquery pom.xml . Those were included in Presto as part of other dependency.

[imjalpreet]

Can you please share the error we saw when we didn't exclude it? I am curious since I can see the same dependency in both the dependency trees.

[nishithakbhaskaran]

logs.docx

@imjalpreet Please see the above log file.

[imjalpreet]

@nishithakbhaskaran Thank you for sharing the logs. Can we assess how complex it would be to fix these errors instead of simply excluding them from the check?

Let's try upgrading all three components to their latest required versions based on the error log and see if any new issues arise.

Upgrade com.google.auth:google-auth-library-oauth2-http to 1.22.0

Add com.google.auth:google-auth-library-credentials to dependencyManagement with version 1.22.0

Add org.conscrypt:conscrypt-openjdk-uber to dependencyManagement with version 2.5.2

[nishithakbhaskaran]

@imjalpreet I have updated the same as suggested, but after that it shows lot more dependency with Require upper bound dependencies error in the bigquery pom.

[nishithakbhaskaran]

Hi @imjalpreet @tdcmeehan Addressed the comments. Along with that I need to handle some other upperbound dependency failures in the dependencymanagement tag.

[imjalpreet]

@nishithakbhaskaran Thanks for the changes! LGTM now.

I just want to confirm if we tested the SELECT query with BigQuery after making these final changes.

[nishithakbhaskaran]

@imjalpreet Sure, I have verified the select query after the changes and it is working as expected.

presto> SELECT * FROM bigquery.team_lakehouse_engine_1.emp;
 id |  name  
----+--------
  1 | lukman 
(1 row)