Add support for pluggable Custom Presto Authenticators #24111

imsayari404 · 2024-11-21T10:39:51Z

Description

A pluggable authenticator in Presto allows the authentication process to be customized based on specific use cases, such as integrating with different identity providers or token validation strategies.

Motivation and Context

Fixes #24052

Test Plan

Added Unit Tests

Contributor checklist

Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Security Changes
* Add support for pluggable Custom Presto Authenticators :pr:`#24111`

pramodsatya

Thanks @imsayari404, could you please add a test? Will the JwtAuthenticator and PasswordAuthenticator be refactored, as suggested in #24053 (review), in this PR?

pramodsatya · 2024-11-21T13:40:57Z

presto-main/src/main/java/com/facebook/presto/server/security/PrestoAuthenticator.java

+
+import static java.util.Objects.requireNonNull;
+
+public class PrestoAuthenticator


Should this be an interface?

The PrestoAuthenticator class does not need to be an interface because it serves as a concrete adapter between the Airlift Authenticator interface and the pluggable design provided by PrestoAuthenticator and PrestoAuthenticatorFactory SPI. Its role is to delegate authentication to the PrestoAuthenticatorManager.

@pramodsatya I understand why you might be confused. We have an interface called PrestoAuthenticator in the presto-spi package with the same name.

@tdcmeehan Currently, we've followed the same naming convention as was done for the PasswordAuthenticator SPI. This could lead to confusion since we have an SPI with the same name as the PasswordAuthenticator class in the presto-main package. Do you think we should refactor the class names in presto-main to eliminate the confusion?

Yes. How about CustomPrestoAuthenticator?

steveburnett

Thanks for the doc! A couple of rephrasing suggestions for conciseness.

Also - because this is a new page - you must add

develop/presto-authenticator

to https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/develop.rst

so the new page will show up on the Developer Guide index page https://prestodb.io/docs/current/develop.html .

presto-docs/src/main/sphinx/develop/presto-authenticator.rst

imjalpreet · 2024-11-25T23:07:24Z

Will the JwtAuthenticator and PasswordAuthenticator be refactored, as suggested in #24053 (review), in this PR?

@pramodsatya There has been a slight change since my last comment on this issue. After discussions with @tdcmeehan, we introduced a new and more generic SPI that is independent of the current Authenticators. This SPI can be used to implement any type of custom authenticator, without being limited to just a custom implementation of JWT or Password Authenticators.

We decided to keep the current implementation of Password and JWT authenticators unchanged to avoid introducing a breaking change.

imjalpreet · 2024-12-06T19:36:55Z

@tdcmeehan can you please have a look whenever you get a chance? Thanks!

steveburnett

Thanks for the revisions! The page content looks good to me.

However, because this is a new page in the Presto documentation, you must add

develop/presto-authenticator

to https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/develop.rst

so the new page will show up on the Developer Guide index page in the Presto documentation.

tdcmeehan · 2024-12-12T19:41:29Z

presto-main/src/main/java/com/facebook/presto/server/security/PrestoAuthenticator.java

+            throws AuthenticationException
+    {
+        try {
+            return authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(request);


HttpServletRequest is a little broad because it also returns the input stream of the actual request. In theory, someone could call that in a plugin. I think that should be a loud failure if that happens. Can you implement a subclass of HttpServletRequest, which wraps an inner HttpServletRequest, but throws if you attempt to use any method which modifies the request, or reads something which doesn't support repeatable reads (such as getInputStream)?

I've implemented the changes as suggested. I created a subclass of HttpServletRequest that wraps an inner HttpServletRequest and throws an exception if any method is called that modifies the request or accesses non-repeatable data like getInputStream. Let me know if there's anything else you'd like me to adjust.

tdcmeehan · 2024-12-13T15:53:54Z

presto-spi/src/main/java/com/facebook/presto/spi/security/RestrictedHttpServletRequest.java

+    @Override
+    public String getPathTranslated()
+    {
+        return super.getPathTranslated();
+    }


It's not necessary right? Just omit this and it will use the parent method.

tdcmeehan · 2024-12-13T15:54:10Z

presto-spi/src/main/java/com/facebook/presto/spi/security/RestrictedHttpServletRequest.java

+import java.util.Enumeration;
+import java.util.Map;
+
+public class RestrictedHttpServletRequest


Let's call it

Suggested change

public class RestrictedHttpServletRequest

public class ReadOnlyHttpServletRequest

tdcmeehan · 2024-12-13T19:08:32Z

presto-main/src/main/java/com/facebook/presto/server/security/PrestoAuthenticator.java

+            throws AuthenticationException
+    {
+        try {
+            //wrapped the original HttpServletRequest in a RestrictedHttpServletRequest


No need for this comment, it is self evident

I agree. I'll remove the unnecessary comment and rename the file to CustomPrestoAuthenticator as suggested.

tdcmeehan · 2024-12-13T19:09:59Z

presto-main/src/main/java/com/facebook/presto/server/security/PrestoAuthenticator.java

+
+import static java.util.Objects.requireNonNull;
+
+public class PrestoAuthenticator


Yes. How about CustomPrestoAuthenticator?

tdcmeehan

Please squash commits.

tdcmeehan · 2024-12-13T20:12:28Z

presto-spi/src/main/java/com/facebook/presto/spi/security/ReadOnlyHttpServletRequest.java

+    public String getQueryString()
+    {
+        return super.getQueryString();
+    }
+
+    @Override
+    public String getRemoteUser()
+    {
+        return super.getRemoteUser();
+    }
+
+    @Override
+    public boolean isUserInRole(String role)
+    {
+        return super.isUserInRole(role);
+    }
+
+    @Override
+    public Principal getUserPrincipal()
+    {
+        return super.getUserPrincipal();
+    }
+
+    @Override
+    public String getRequestedSessionId()
+    {
+        return super.getRequestedSessionId();
+    }
+
+    @Override
+    public String getRequestURI()
+    {
+        return super.getRequestURI();
+    }
+
+    @Override
+    public StringBuffer getRequestURL()
+    {
+        return super.getRequestURL();
+    }
+
+    @Override
+    public String getServletPath()
+    {
+        return super.getServletPath();
+    }
+
+    @Override
+    public HttpSession getSession(boolean create)
+    {
+        return super.getSession(create);
+    }
+
+    @Override
+    public HttpSession getSession()
+    {
+        return super.getSession();
+    }
+
+    @Override
+    public String changeSessionId()
+    {
+        return super.changeSessionId();
+    }
+
+    @Override
+    public boolean isRequestedSessionIdValid()
+    {
+        return super.isRequestedSessionIdValid();
+    }
+
+    @Override
+    public boolean isRequestedSessionIdFromCookie()
+    {
+        return super.isRequestedSessionIdFromCookie();
+    }
+
+    @Override
+    public boolean isRequestedSessionIdFromURL()
+    {
+        return super.isRequestedSessionIdFromURL();
+    }
+
+    @Override
+    public boolean isRequestedSessionIdFromUrl()
+    {
+        return super.isRequestedSessionIdFromUrl();
+    }
+
+    @Override
+    public Map<String, String[]> getParameterMap()
+    {
+        return super.getParameterMap();
+    }
+
+    @Override
+    public String[] getParameterValues(String name)
+    {
+        return super.getParameterValues(name);
+    }


Suggested change

@Override

public String getAuthType()

{

return super.getAuthType();

}

@Override

public Cookie[] getCookies()

{

return super.getCookies();

}

@Override

public long getDateHeader(String name)

{

return super.getDateHeader(name);

}

@Override

public String getHeader(String name)

{

return super.getHeader(name);

}

@Override

public Enumeration<String> getHeaders(String name)

{

return super.getHeaders(name);

}

@Override

public Enumeration<String> getHeaderNames()

{

return super.getHeaderNames();

}

@Override

public int getIntHeader(String name)

{

return super.getIntHeader(name);

}

@Override

public String getMethod()

{

return super.getMethod();

}

@Override

public String getPathInfo()

{

return super.getPathInfo();

}

@Override

public String getContextPath()

{

return super.getContextPath();

}

@Override

public String getQueryString()

{

return super.getQueryString();

}

@Override

public String getRemoteUser()

{

return super.getRemoteUser();

}

@Override

public boolean isUserInRole(String role)

{

return super.isUserInRole(role);

}

@Override

public Principal getUserPrincipal()

{

return super.getUserPrincipal();

}

@Override

public String getRequestedSessionId()

{

return super.getRequestedSessionId();

}

@Override

public String getRequestURI()

{

return super.getRequestURI();

}

@Override

public StringBuffer getRequestURL()

{

return super.getRequestURL();

}

@Override

public String getServletPath()

{

return super.getServletPath();

}

@Override

public HttpSession getSession(boolean create)

{

return super.getSession(create);

}

@Override

public HttpSession getSession()

{

return super.getSession();

}

@Override

public String changeSessionId()

{

return super.changeSessionId();

}

@Override

public boolean isRequestedSessionIdValid()

{

return super.isRequestedSessionIdValid();

}

@Override

public boolean isRequestedSessionIdFromCookie()

{

return super.isRequestedSessionIdFromCookie();

}

@Override

public boolean isRequestedSessionIdFromURL()

{

return super.isRequestedSessionIdFromURL();

}

@Override

public boolean isRequestedSessionIdFromUrl()

{

return super.isRequestedSessionIdFromUrl();

}

@Override

public Map<String, String[]> getParameterMap()

{

return super.getParameterMap();

}

@Override

public String[] getParameterValues(String name)

{

return super.getParameterValues(name);

}

Just remove these, they will all use the parent's implementation if they are not specified.

tdcmeehan · 2024-12-16T15:58:55Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+            ReadOnlyHttpServletRequest restrictedRequest = new ReadOnlyHttpServletRequest(request);
+            return authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(restrictedRequest);
+        }
+        catch (RuntimeException e) {


Can you make this exception more specific?

Let's just let it throw.

tdcmeehan · 2024-12-16T16:00:11Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+            ReadOnlyHttpServletRequest restrictedRequest = new ReadOnlyHttpServletRequest(request);
+            return authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(restrictedRequest);


Suggested change

ReadOnlyHttpServletRequest restrictedRequest = new ReadOnlyHttpServletRequest(request);

return authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(restrictedRequest);

authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(new ReadOnlyHttpServletRequest(request));

tdcmeehan · 2024-12-16T16:08:37Z

presto-main/src/main/java/com/facebook/presto/server/security/PrestoAuthenticatorManager.java

+    public void setRequired()
+    {
+        required.set(true);
+    }


Instead of this flag, let's just pass in the SecurityConfig as a parameter to this class and @Inject it. And just check in the constructor if CUSTOM is one of the authentication types. Then we can make it immutable, private final boolean.

Finally, let's name it something else, like customAuthenticatorRequested.

tdcmeehan · 2024-12-16T16:12:09Z

presto-spi/pom.xml

@@ -53,6 +53,11 @@
            <artifactId>jol-core</artifactId>
        </dependency>

+        <dependency>
+            <groupId>javax.servlet</groupId>
+            <artifactId>javax.servlet-api</artifactId>


I believe this could be problematic. I don't think it's a great idea to add the servlet API to the SPI. Instead, wondering if we can do something similar, like just authenticating the headers. That way, instead of the API surface being a ServletRequest, it could just be a map representing the headers.

imjalpreet · 2025-01-02T09:22:13Z

presto-lark-sheets/pom.xml

We can undo this change since we are removing the dependency from HttpServletRequest in the new SPI.

imjalpreet · 2025-01-02T09:50:41Z

presto-password-authenticators/pom.xml

We can undo this change since we are removing the dependency from HttpServletRequest in the new SPI.

imjalpreet

@imsayari404 thanks for the changes, I have taken another pass and added a few comments.

imjalpreet · 2025-01-02T09:52:04Z

presto-main/src/main/java/com/facebook/presto/server/PluginManager.java

@@ -147,6 +151,8 @@ public PluginManager(
            QueryPreparerProviderManager queryPreparerProviderManager,
            AccessControlManager accessControlManager,
            PasswordAuthenticatorManager passwordAuthenticatorManager,
+            SecurityConfig securityConfig,


nit: this is not required, please remove this.

imjalpreet · 2025-01-02T09:55:09Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+    }
+
+    // Utility method to extract headers from HttpServletRequest
+    private Map<String, String> getHeadersMap(HttpServletRequest request)


nit: we can move this method after all the public methods

imjalpreet · 2025-01-02T09:58:01Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+    // Utility method to extract headers from HttpServletRequest
+    private Map<String, String> getHeadersMap(HttpServletRequest request)
+    {
+        Map<String, String> headers = new HashMap<>();


Some headers can be sent by clients as several headers each with a different value. So, we should update this to Map<String, List<String>>

imjalpreet · 2025-01-02T10:07:16Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+        Enumeration<String> headerNames = request.getHeaderNames();
+        while (headerNames.hasMoreElements()) {
+            String headerName = headerNames.nextElement();
+            String headerValue = request.getHeader(headerName);


We can use request.getHeaders(headerName) to get all the values.

imjalpreet · 2025-01-02T10:16:54Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+            return authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(headers);
+        }
+        catch (AccessDeniedException e) {
+            throw e;


nit: let's wrap this in AuthenticationException

Suggested change

throw e;

throw new AuthenticationException(e.getMessage());

imjalpreet · 2025-01-02T10:52:24Z

presto-main/src/test/java/com/facebook/presto/server/security/TestPrestoAuthenticator.java

+            return (httpRequest) -> {
+                // TEST_HEADER will have value of the form PART1:PART2
+                String[] header = httpRequest.get(TEST_HEADER).split(":");
+
+                if (header[0].equals(this.validHeaderValue)) {
+                    return new BasicPrincipal(header[1]);
+                }
+
+                throw new AccessDeniedException("Authentication Failed!");
+            };


After making the headers map in SPI to Map<String, List<String>>, we can refactor this.

Suggested change

return (httpRequest) -> {

// TEST_HEADER will have value of the form PART1:PART2

String[] header = httpRequest.get(TEST_HEADER).split(":");

if (header[0].equals(this.validHeaderValue)) {

return new BasicPrincipal(header[1]);

}

throw new AccessDeniedException("Authentication Failed!");

};

return (headers) -> {

// TEST_HEADER will have value of the form PART1:PART2

String[] header = headers.get(TEST_HEADER).get(0).split(":");

if (header[0].equals(this.validHeaderValue)) {

return new BasicPrincipal(header[1]);

}

throw new AccessDeniedException("Authentication Failed!");

};

imjalpreet · 2025-01-02T10:53:40Z

presto-spi/src/main/java/com/facebook/presto/spi/security/HttpServletRequestHeaders.java

please remove this class since this is unused

imjalpreet · 2025-01-02T10:54:25Z

presto-spi/src/main/java/com/facebook/presto/spi/security/PrestoAuthenticator.java

+     * @return the authenticated Principal
+     * @throws AccessDeniedException if not allowed
+     */
+    Principal createAuthenticatedPrincipal(Map<String, String> headers);


Change the headers map to Map<String, List<String>>

imjalpreet · 2025-01-02T10:54:58Z

presto-spi/src/main/java/com/facebook/presto/spi/security/ReadOnlyHttpServletRequest.java

We can remove this class as this is unused

imjalpreet · 2025-01-02T10:55:14Z

presto-spi/src/main/java/com/facebook/presto/spi/security/RequestHeaders.java

Please remove this as well

imjalpreet

@imsayari404 thanks, mostly LGTM now, just a few minor comments.

imjalpreet · 2025-01-02T16:09:00Z

presto-lark-sheets/pom.xml

@@ -75,6 +75,7 @@
        </dependency>

        <!-- Presto SPI -->
+


nit: empty line can be removed

imjalpreet · 2025-01-02T16:14:53Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+        Map<String, List<String>> headers = new HashMap<>();
+        Enumeration<String> headerNames = request.getHeaderNames();
+        while (headerNames.hasMoreElements()) {
+            String headerName = headerNames.nextElement();
+            Enumeration<String> headerValues = request.getHeaders(headerName);
+            List<String> valuesList = new ArrayList<>();
+            while (headerValues.hasMoreElements()) {
+                valuesList.add(headerValues.nextElement());
+            }
+            headers.put(headerName, valuesList);
+        }
+        return headers;


We can refactor this method and use Java Stream API

Suggested change

Map<String, List<String>> headers = new HashMap<>();

Enumeration<String> headerNames = request.getHeaderNames();

while (headerNames.hasMoreElements()) {

String headerName = headerNames.nextElement();

Enumeration<String> headerValues = request.getHeaders(headerName);

List<String> valuesList = new ArrayList<>();

while (headerValues.hasMoreElements()) {

valuesList.add(headerValues.nextElement());

}

headers.put(headerName, valuesList);

}

return headers;

return Collections.list(request.getHeaderNames())

.stream()

.collect(Collectors.toMap(

headerName -> headerName,

headerName -> Collections.list(request.getHeaders(headerName))

));

imjalpreet · 2025-01-02T16:16:51Z

...to-main/src/test/java/com/facebook/presto/server/security/TestCustomPrestoAuthenticator.java

+
+    private Map<String, List<String>> getHeadersMap(HttpServletRequest request)
+    {
+        Map<String, List<String>> headers = new HashMap<>();


Similar to the previous comment, please refactor this as well.

imjalpreet

@imsayari404 thanks, changes LGTM, can we squash the commits into relevant commits?

imjalpreet

LGTM 👍🏼

steveburnett

LGTM! (docs)

Pulled updated branch, new local doc build, looks good. Thanks!

imsayari404 · 2025-01-07T11:41:27Z

Hi @tdcmeehan ,
I’ve addressed all the requested changes in the PR, and it’s ready for another round of review. Could you please take a look when you get a chance? Let me know if there’s anything else that needs to be updated.

tdcmeehan

Just some nits, otherwise LGTM

tdcmeehan · 2025-01-08T18:37:45Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+            ReadOnlyHttpServletRequest restrictedRequest = new ReadOnlyHttpServletRequest(request);
+            return authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(restrictedRequest);
+        }
+        catch (RuntimeException e) {


Let's just let it throw.

tdcmeehan · 2025-01-08T18:37:58Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+    {
+        return Collections.list(request.getHeaderNames())
+                .stream()
+                .collect(Collectors.toMap(


Suggested change

.collect(Collectors.toMap(

.collect(toImmutableMap(

tdcmeehan · 2025-01-08T18:38:32Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+    // Utility method to extract headers from HttpServletRequest
+    private Map<String, List<String>> getHeadersMap(HttpServletRequest request)
+    {
+        return Collections.list(request.getHeaderNames())


Suggested change

return Collections.list(request.getHeaderNames())

return list(request.getHeaderNames())

tdcmeehan · 2025-01-08T18:38:56Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+                .stream()
+                .collect(Collectors.toMap(
+                        headerName -> headerName,
+                        headerName -> Collections.list(request.getHeaders(headerName))));


Suggested change

headerName -> Collections.list(request.getHeaders(headerName))));

headerName -> list(request.getHeaders(headerName))));

imjalpreet

One minor change, otherwise LGTM

imjalpreet · 2025-01-09T09:02:41Z

presto-main/src/main/java/com/facebook/presto/server/security/CustomPrestoAuthenticator.java

+    public Principal authenticate(HttpServletRequest request)
+            throws AuthenticationException
+    {
+            // Extracting headers into a Map


We will need to catch AccessDeniedException here and throw it as AuthenticationException, we cannot remove that.

We can remove the catch clause for RuntimeException but we need to catch AccessDeniedException.

Co-authored-by: Namya Sehgal <[email protected]>

Add TestingPrestoAuthenticatorFactory Co-authored-by: Sayari Mukherjee <[email protected]>

imjalpreet

@imsayari404 Thanks for the PR, LGTM!

imjalpreet · 2025-01-10T16:25:48Z

@tdcmeehan This should be good for another review. Thank you.

prestodb-ci added the from:IBM PR from IBM label Nov 21, 2024

prestodb-ci requested review from a team and pramodsatya and removed request for a team November 21, 2024 10:39

pramodsatya reviewed Nov 21, 2024

View reviewed changes

tdcmeehan self-assigned this Nov 21, 2024

steveburnett reviewed Nov 21, 2024

View reviewed changes

presto-docs/src/main/sphinx/develop/presto-authenticator.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/develop/presto-authenticator.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/develop/presto-authenticator.rst Outdated Show resolved Hide resolved

imjalpreet force-pushed the custom_presto_authenticator branch 2 times, most recently from 5a9b144 to caefe42 Compare November 25, 2024 23:01

imjalpreet marked this pull request as ready for review November 25, 2024 23:14

imjalpreet requested review from elharo, a team and shrinidhijoshi as code owners November 25, 2024 23:14

imjalpreet requested a review from presto-oss November 25, 2024 23:14

steveburnett requested changes Dec 6, 2024

View reviewed changes

tdcmeehan requested changes Dec 12, 2024

View reviewed changes

imsayari404 force-pushed the custom_presto_authenticator branch 2 times, most recently from 28a51c9 to 1ad5092 Compare December 13, 2024 08:20

tdcmeehan requested changes Dec 13, 2024

View reviewed changes

tdcmeehan reviewed Dec 13, 2024

View reviewed changes

tdcmeehan requested changes Dec 13, 2024

View reviewed changes

imsayari404 force-pushed the custom_presto_authenticator branch from c175051 to 44d8042 Compare December 14, 2024 05:38

tdcmeehan requested changes Dec 16, 2024

View reviewed changes

imjalpreet requested changes Jan 2, 2025

View reviewed changes

imjalpreet reviewed Jan 2, 2025

View reviewed changes

imsayari404 force-pushed the custom_presto_authenticator branch from 19c5bca to 2c9848c Compare January 2, 2025 17:33

imjalpreet reviewed Jan 3, 2025

View reviewed changes

imjalpreet requested a review from tdcmeehan January 3, 2025 02:37

imsayari404 force-pushed the custom_presto_authenticator branch 2 times, most recently from b1590a7 to 0220514 Compare January 3, 2025 05:59

imjalpreet previously approved these changes Jan 3, 2025

View reviewed changes

steveburnett previously approved these changes Jan 3, 2025

View reviewed changes

tdcmeehan reviewed Jan 8, 2025

View reviewed changes

imsayari404 dismissed stale reviews from steveburnett and imjalpreet via c873a49 January 9, 2025 07:05

imsayari404 force-pushed the custom_presto_authenticator branch from 0220514 to c873a49 Compare January 9, 2025 07:05

imsayari404 requested review from imjalpreet and tdcmeehan January 9, 2025 07:08

imjalpreet requested changes Jan 9, 2025

View reviewed changes

imsayari404 force-pushed the custom_presto_authenticator branch from c873a49 to 415ef55 Compare January 9, 2025 09:50

imsayari404 requested a review from imjalpreet January 9, 2025 09:53

imsayari404 and others added 2 commits January 9, 2025 16:01

Add support for pluggable Custom Presto Authenticators

6a73d49

Co-authored-by: Namya Sehgal <[email protected]>

Add tests for Custom Presto Authenticators

f6fe09f

Add TestingPrestoAuthenticatorFactory Co-authored-by: Sayari Mukherjee <[email protected]>

imsayari404 force-pushed the custom_presto_authenticator branch from 415ef55 to f6fe09f Compare January 9, 2025 10:37

imjalpreet approved these changes Jan 9, 2025

View reviewed changes

tdcmeehan approved these changes Jan 10, 2025

View reviewed changes

tdcmeehan merged commit 9fbbc51 into prestodb:master Jan 10, 2025
53 checks passed

This was referenced Jan 28, 2025

Add release notes for 0.291 #24445

Merged

Add release notes for 0.291 #24448

Closed


		import static java.util.Objects.requireNonNull;

		public class PrestoAuthenticator

	public class RestrictedHttpServletRequest
	public class ReadOnlyHttpServletRequest

		ReadOnlyHttpServletRequest restrictedRequest = new ReadOnlyHttpServletRequest(request);
		return authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(restrictedRequest);

	ReadOnlyHttpServletRequest restrictedRequest = new ReadOnlyHttpServletRequest(request);
	return authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(restrictedRequest);
	authenticatorManager.getAuthenticator().createAuthenticatedPrincipal(new ReadOnlyHttpServletRequest(request));

	return Collections.list(request.getHeaderNames())
	return list(request.getHeaderNames())

	headerName -> Collections.list(request.getHeaders(headerName))));
	headerName -> list(request.getHeaders(headerName))));

Add support for pluggable Custom Presto Authenticators #24111

Add support for pluggable Custom Presto Authenticators #24111

Conversation

imsayari404 commented Nov 21, 2024 • edited by imjalpreet Loading

Description

Motivation and Context

Test Plan

Contributor checklist

Release Notes

pramodsatya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

imjalpreet commented Nov 25, 2024

imjalpreet commented Dec 6, 2024

steveburnett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imjalpreet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imjalpreet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imjalpreet left a comment

Choose a reason for hiding this comment

imjalpreet left a comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

imsayari404 commented Jan 7, 2025

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imjalpreet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imjalpreet left a comment

Choose a reason for hiding this comment

imjalpreet commented Jan 10, 2025

imsayari404 commented Nov 21, 2024 •

edited by imjalpreet

Loading