Fixed Functional Test Failures #24123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdcmeehan
reviewed
Nov 25, 2024
| } | ||
|
|
||
| try (OutputStream output = new FileOutputStream(file); | ||
| try (OutputStream output = new FileOutputStream(file, false); |
There was a problem hiding this comment.
Suggested change
| try (OutputStream output = new FileOutputStream(file, false); | |
| try (OutputStream output = new FileOutputStream(file); |
Aren't these equivalent?
| String arrayElementTypeName = metaData.getColumnTypeName(i); | ||
| Type elementType = mapSqlTypeNameToType(arrayElementTypeName); | ||
| types.add(new ArrayType(elementType)); | ||
| if (typeName.startsWith("ARRAY(") && typeName.endsWith(")")) { |
There was a problem hiding this comment.
Could we use TypeSignature.parseTypeSignature to retrieve the base type name?
abevk2023
force-pushed
the
fix_functional_tests
branch
from
54ba626 to
ee4cb1c
Compare
abevk2023
force-pushed
the
fix_functional_tests
branch
from
ee4cb1c to
e4f9256
Compare
abevk2023
force-pushed
the
fix_functional_tests
branch
from
e4f9256 to
affbf8c
Compare
prestodb-ci
requested review from
a team,
bibith4 and
namya28
and removed request for
a team
|
Saved that user @abevk2023 is from IBM |
tdcmeehan
reviewed
Dec 13, 2024
| @@ -244,6 +244,12 @@ | |||
| <artifactId>presto-jdbc</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Can we avoid this new dependency?
There was a problem hiding this comment.
This dependency is required for the MountableFile. Without this, there is runtime error while starting container.
java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemProperties
at org.apache.commons.compress.archivers.tar.TarArchiveEntry.normalizeFileName(TarArchiveEntry.java:231)
at org.apache.commons.compress.archivers.tar.TarArchiveEntry.<init>(TarArchiveEntry.java:490)
at org.testcontainers.utility.MountableFile.recursiveTar(MountableFile.java:355)
at org.testcontainers.utility.MountableFile.transferTo(MountableFile.java:327)
at org.testcontainers.containers.ContainerState.copyFileToContainer(ContainerState.java:306)
at org.testcontainers.containers.ContainerState.copyFileToContainer(ContainerState.java:282)
at java.base/java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:430)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322)
at com.facebook.presto.nativeworker.ContainerQueryRunner.<init>(ContainerQueryRunner.java:97)
tdcmeehan
approved these changes
Dec 16, 2024
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves following failures in functional tests.