[native] Add Apache Arrow Flight Connector #24504

BryanCutler · 2025-02-05T21:47:30Z

Description

Add Prestissimo support for Apache Arrow Flight connectors.

The native Arrow Flight connector can be used to connect to any Arrow Flight enabled Data Source. The metadata layer is handled by the Presto coordinator and does not need to be re-implemented in C++. Any Java connector that inherits from presto-base-arrow-flight can use this connector as it's counterpart for the Prestissimo layer.

Different Arrow-Flight enabled data sources can differ in authentication styles. A plugin-style interface is provided to handle such cases with custom authentication code by extending arrow_flight::auth::Authenticator.

Motivation and Context

RFC: https://github.com/prestodb/rfcs/blob/main/RFC-0004-arrow-flight-connector.md#prestissimo-implementation

Continues from #24082

Impact

Arrow Flight based connector will be supported in Prestissimo.

Test Plan

Unit Tests set up a testing Arrow Flight server and exchange data using the new connector.

Contributor checklist

Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Prestissimo (Native Execution)
* Add support for Apache Arrow Flight connectors :pr:`24504`

steveburnett · 2025-02-05T21:49:31Z

Thanks for the release note!

New release note guidelines. Please remove the manual PR link in the following format from the release note entries for this PR.


:pr:`**`

I have updated the Release Notes Guidelines to remove the examples of manually adding the PR link.

BryanCutler · 2025-02-05T21:52:53Z

Great work from @Rijin-N in #24082. I didn't make any major changes, just updated the protocol to what was merged in Java from #24427, fixed some build issues, added tests for custom authentication and some minor tweaks. I'll try to highlight my changes below.

steveburnett

Thanks for the doc! One nit of formatting.

steveburnett · 2025-02-05T21:53:08Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/tests/data/README.md

+The `tls_certs` directory contains placeholder TLS certificates generated for unit testing the Arrow Flight Connector with TLS enabled. These certificates are not intended for production use and should only be used in the context of unit tests.
+
+### Generating TLS Certificates
+To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:


Suggested change

To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:

To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:

Add a line after this blank line to separate this text and the command. Without the line, it looks like this:

BryanCutler · 2025-02-05T21:56:01Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/ArrowFlightConnector.cpp

+  }
+}
+
+void FlightDataSource::addSplit(std::shared_ptr<ConnectorSplit> split) {


Did some minor cleanup in this method to simply use of the serialized FlightEndpoint

BryanCutler · 2025-02-05T22:00:19Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/CMakeLists.txt

+# limitations under the License.
+find_package(Arrow REQUIRED)
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(ARROW_FLIGHT REQUIRED IMPORTED_TARGET GLOBAL arrow-flight)


I needed to add GLOBAL for using PkgConfig to prevent an -larrow-flight linker error. This seems like a better general solution to reference the libraries, see https://stackoverflow.com/questions/29191855/what-is-the-proper-way-to-use-pkg-config-from-cmake for more details

BryanCutler · 2025-02-05T22:01:06Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/FlightConfig.cpp

+  return config_->get<bool>(kServerVerify, true);
+}
+
+std::optional<std::string> FlightConfig::serverSslCertificate() {


This was folly::Optional, changed to be consistent

BryanCutler · 2025-02-05T22:03:02Z

...ive-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorAuthTest.cpp

@@ -0,0 +1,251 @@
+/*


Added these tests to verify adding a custom authenticator works

BryanCutler · 2025-02-05T22:04:16Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/tests/CMakeLists.txt

+
+target_link_libraries(
+  presto_flight_connector_infra_test presto_protocol
+  presto_flight_connector_test_lib GTest::gtest GTest::gtest_main ${GLOG})


Added G stuff due to linker error

BryanCutler · 2025-02-05T22:06:01Z

...tive-execution/presto_cpp/main/connectors/arrow_flight/tests/utils/FlightConnectorTestBase.h

+  virtual arrow::flight::Location getServerLocation();
+
+  virtual void setFlightServerOptions(
+      arrow::flight::FlightServerOptions* serverOptions) {}


Server options now specified by subclasses

steveburnett

LGTM! (docs)

BryanCutler · 2025-02-05T23:01:24Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/auth/Authenticator.cpp

+#include "velox/common/base/Exceptions.h"
+
+namespace facebook::presto::connector::arrow_flight::auth {
+namespace {


changed this to be in an anonymous namespace, instead of static

BryanCutler · 2025-02-05T23:05:18Z

presto-native-execution/presto_cpp/main/SystemConnector.cpp

@@ -351,7 +351,8 @@ std::unique_ptr<velox::connector::ConnectorSplit>
 SystemPrestoToVeloxConnector::toVeloxSplit(
    const protocol::ConnectorId& catalogId,
    const protocol::ConnectorSplit* const connectorSplit,
-    const protocol::SplitContext* splitContext) const {
+    const protocol::SplitContext* splitContext,
+    const std::map<std::string, std::string>& extraCredentials) const {


@Rijin-N @elbinpallimalilibm is there a specific requirement to use these extraCredentials to authenticate a Flight client? I would think most users would prefer to authenticate the client with a token in the header, rather than use this. The Java Arrow Connector does not have this either.

@BryanCutler the base Presto (Java) Flight Connector is a template and not a full connector, and elects not to do authentication at all. The idea is that the authentication mechanism is largely dependent on the specific Flight server, so the whole business of authentication should be dealt with by the specialized connectors.

The problem we need to solve is that different Presto users may have different sets of access permissions on the connected Arrow Flight server. In this case we need to "pass through" the Presto user's authentication to the connected Flight Server, which means we somehow need to send the credentials from the Presto coordinator to the Presto workers.

In Java, there is an Identity API which we can use through connectorSession.getIdentity().getExtraCredentials().
IBM's specialization of the base Flight connector uses this API to pass the user's token to the workers. This isn't possible in Prestissimo because Velox connectors have no concept of Identity at all, so we need to pass the token in the split.

This issue provides more context:
#22849

There's also a corresponding Velox issue:
facebookincubator/velox#10107

Thanks for the background @ashkrisk . This related issues you linked are proposing adding an Identity data structure that all prestissimo connectors can access, but it is so far unresolved. I think this is a better solution that simply passing through a map, so we should hold off of adding these extraCredentials until we can get the right API with an Identity. WDYT?
cc @majetideepak @aditi-pandit

@BryanCutler we need this to get the multi-user setup working (IBM's flavor of the Flight connector relies on it). You can leave this off for now as long as you're able to maintain the diff in IBM code until there's a better solution in OSS.

@ashkrisk we need to make sure we have a discussion and proper design before adding APIs like this, since this also affects other connectors. I believe it was mentioned there could be a security concern if the credentials are added to the split, which is then serialized.

@BryanCutler do we need to get a meeting to talk about this?

I discussed with @majetideepak and @aditi-pandit , and have a possible way forward that I'm looking into, and I'll report back

@BryanCutler With regards to security, any method used to transfer the credentials from the coordinator to the worker requires serialization at some point. This includes the Identity framework available in Java. To ensure security, you need to ensure encrypted connections between all Presto nodes.

Obviously, it's better to have dedicated infra for this, so hopefully you can get together and work something out.

The plan is to incorporate #22859 which will add the extraCredentials to the connector session properties. This will be available to the Flight data source when it is processing the split and can use them for authentication. I'll try to add a test for this if I'm able to.

BryanCutler · 2025-02-06T22:59:07Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/FlightConfig.cpp

+}
+
+bool FlightConfig::serverVerify() {
+  return config_->get<bool>(kServerVerify, false);


Changed default to "false" to be consistent with Java

We probably want the default to be true for both Java and C++, otherwise by default there's no protection against server impersonation. Having this off is good for testing, but in production it's much better to leave it on unless there's a VERY good reason not to.

server verify is by default true in Java

Good point, the default behavior for the Flight client is to raise an error if using TLS and a certificate is provided but verify is disabled, and you need to explicitly disable it when using TLS.

I didn't catch that the Java connector defaults the config to NULL, which translates to true. I think that's confusing and we should not make it nullable. I'll change Java and here to default to true.

updated the Java side in #24518 and changed the default here too

aditi-pandit

Thanks @BryanCutler. Did a quick round of the code.

aditi-pandit · 2025-02-12T03:25:04Z

presto-native-execution/presto_cpp/presto_protocol/presto_protocol.yml

@@ -365,4 +369,7 @@ JavaClasses:
  - presto-main/src/main/java/com/facebook/presto/connector/system/SystemTableLayoutHandle.java
  - presto-main/src/main/java/com/facebook/presto/connector/system/SystemTransactionHandle.java
  - presto-spi/src/main/java/com/facebook/presto/spi/function/AggregationFunctionMetadata.java
-  - presto-function-namespace-managers-common/src/main/java/com/facebook/presto/functionNamespace/JsonBasedUdfFunctionMetadata.java


Why did JsonBasedUdfFunctionMetadata get dropped ?

must have been my mistake, I'll put it back

aditi-pandit · 2025-02-12T04:02:22Z

presto-native-execution/presto_cpp/main/connectors/CMakeLists.txt

+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+if(PRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR)


This condition can be moved below and combined with that at line 18.

aditi-pandit · 2025-02-12T04:04:42Z

presto-native-execution/presto_cpp/main/connectors/ConnectorRegistration.cpp

+
+namespace facebook::presto::connector {
+
+void registerAllPrestoConnectors() {


Nit : Rename registerOptionalConnectors ?

registerConnectors will do as well.
We should also move the existing connector registrations here.

We can do away with the connector namespace since the function name has Connectors.

The file names can also be Registration.h/.cpp since they are in the connectors folder.
presto-native-execution/presto_cpp/main/connectors/Registration.h

Let's move the SystemConnector here as well.

ok sounds good

Let's move the SystemConnector here as well.

@majetideepak should the SystemConnector be under namespace facebook::presto::connector like ArrowFlightConnector?

Could you clarify if you mean the source files SystemConnector.cpp/h or just the registration?

edit: confirmed moving sources for connectors also

aditi-pandit · 2025-02-12T06:07:31Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/Macros.h

+  } while (false)
+
+#define AFC_ASSIGN_OR_RAISE_IMPL(result_name, lhs, rexpr)            \
+  auto&& result_name = (rexpr);                                      \


This macro should be wrap in a do.. while loop as well.

I don't think that will work, the lhs variable gets scoped in the loop. So something like this you can't do anymore

AFC_ASSIGN_OR_RAISE(auto client, FlightClient::Connect(loc, *clientOpts_));

I believe this was taken from https://github.com/facebookincubator/velox/blob/d3f7b3d8c5c67bdcdcad05d9946ae6b87f88d760/velox/functions/prestosql/json/SIMDJsonUtil.h#L36
Which doesn't wrap in a loop either

Actually, it comes from the Arrow source:
https://github.com/apache/arrow/blob/152eb879b4fd4476dadd3cd497bb8d78d3013cef/cpp/src/arrow/result.h#L460

See also the comments around ARROW_ASSIGN_OR_RAISE in the source:
https://github.com/apache/arrow/blob/152eb879b4fd4476dadd3cd497bb8d78d3013cef/cpp/src/arrow/result.h#L467-L487

aditi-pandit · 2025-02-12T06:18:50Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/ArrowPrestoToVeloxConnector.cpp

+std::unique_ptr<velox::connector::ColumnHandle>
+ArrowPrestoToVeloxConnector::toVeloxColumnHandle(
+    const protocol::ColumnHandle* column,
+    const TypeParser& typeParser) const {


Wrap unused parameters in comments... /typeParser/

aditi-pandit · 2025-02-12T06:49:37Z

...tive-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorTlsTest.cpp

The file names should match the class names. Might be good to use all classes with ArrowFlight consistently,

aditi-pandit · 2025-02-12T06:56:50Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/tests/TestFlightServerTest.cpp

+
+std::unique_ptr<TestFlightServer> TestFlightServerTest::server;
+
+TEST_F(TestFlightServerTest, basicTest) {


Don't understand the purpose of this test. It doesn't seem to be related to the Connector.

I'm not too sure either, it's part of presto_flight_connector_infra_test tests, which is separate. It starts a server, adds data, then makes it's own client to get the flight stream - not using the connector. So it seems to be testing that the test server can serve Flight clients correctly, but that is also covered with the regular connector tests. @Rijin-N could you comment on this test?

The goal here is to run a simple test to be confident that the Test Flight Server is working correctly. Now, any failures that happen in the actual connector tests can be safely assumed to be a problem with the connector and not with the server, potentially making things easier to debug.

This is like the difference between testing each component vs having only integration tests.

aditi-pandit · 2025-02-12T07:09:36Z

...tive-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorTlsTest.cpp

+                {1, 12, 2, std::numeric_limits<int64_t>::max()})}));
+
+    auto idVec = makeFlatVector<int64_t>(
+        {1, 12, 2, std::numeric_limits<int64_t>::max()});


Abstract a variable for {1, 12, 2, std::numeric_limits<int64_t>::max()} so that it can be used in the input and result vector.

aditi-pandit · 2025-02-12T07:12:51Z

...tive-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorTlsTest.cpp

+
+namespace {
+
+namespace velox = facebook::velox;


Haven't seen this style of shorthand for namespaces in Prestissimo code. Can these be removed ?

aditi-pandit · 2025-02-12T07:16:42Z

...-native-execution/presto_cpp/main/connectors/arrow_flight/tests/ArrowFlightConnectorTest.cpp

+      "missing columnHandle for column 'value'");
+}
+
+TEST_F(FlightConnectorTest, dataSourceTest) {


test names shouldn't have the word "Test" in them. Please fix the names.

majetideepak · 2025-02-13T18:03:02Z

presto-native-execution/Makefile

@@ -45,6 +45,9 @@ endif
 ifneq ($(PRESTO_MEMORY_CHECKER_TYPE),)
  EXTRA_CMAKE_FLAGS += -DPRESTO_MEMORY_CHECKER_TYPE=$(PRESTO_MEMORY_CHECKER_TYPE)
 endif
+ifneq ($(PRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR),)


Let's remove this.
Users can set EXTRA_CMAKE_FLAGS directly. Exiting options will be removed from this Makefile.

majetideepak · 2025-02-13T18:03:57Z

presto-native-execution/README.md

@@ -115,6 +115,15 @@ follow these steps:
 * For development, use `make debug` to build a non-optimized debug version.
 * Use `make unittest` to build and run tests.

+#### Arrow Flight Connector
+To enable Arrow Flight connector support, set the environment variable:
+`PRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR = "ON"`.


Fix to use EXTRA_CMAKE_FLAGS = -DPRESTO_ENABLE_ARROW_FLIGHT_CONNECTOR=ON

majetideepak · 2025-02-13T18:07:32Z

presto-native-execution/presto_cpp/main/connectors/ConnectorRegistration.cpp

+
+namespace facebook::presto::connector {
+
+void registerAllPrestoConnectors() {


registerConnectors will do as well.
We should also move the existing connector registrations here.

majetideepak · 2025-02-13T18:13:15Z

presto-native-execution/presto_cpp/main/connectors/ConnectorRegistration.cpp

+
+namespace facebook::presto::connector {
+
+void registerAllPrestoConnectors() {


We can do away with the connector namespace since the function name has Connectors.

majetideepak · 2025-02-13T18:14:41Z

presto-native-execution/presto_cpp/main/connectors/ConnectorRegistration.cpp

+
+namespace facebook::presto::connector {
+
+void registerAllPrestoConnectors() {


The file names can also be Registration.h/.cpp since they are in the connectors folder.
presto-native-execution/presto_cpp/main/connectors/Registration.h

majetideepak · 2025-02-13T18:15:45Z

presto-native-execution/presto_cpp/main/connectors/ConnectorRegistration.cpp

+
+namespace facebook::presto::connector {
+
+void registerAllPrestoConnectors() {


Let's move the SystemConnector here as well.

majetideepak · 2025-02-13T18:17:25Z

presto-native-execution/presto_cpp/main/connectors/arrow_flight/ArrowFlightConnector.cpp

+namespace facebook::presto::connector::arrow_flight {
+
+using namespace arrow::flight;
+using namespace velox;


Let's remove these.
Explicitly using velox:: where needed makes the code readable.

majetideepak · 2025-02-13T18:18:56Z

presto-native-execution/scripts/setup-adapters.sh

@@ -35,15 +35,73 @@ function install_prometheus_cpp {
  cmake_install -DBUILD_SHARED_LIBS=ON -DENABLE_PUSH=OFF -DENABLE_COMPRESSION=OFF
 }

+function install_abseil {


abseil and grpc are installed by the velox setup script already.
We can align the versions.

@majetideepak they are the same versions, but they are done in the call to install_gcs-sdk-cpp so we can't call them directly unless we update the velox script.

majetideepak · 2025-02-13T18:19:26Z

presto-native-execution/scripts/setup-adapters.sh

+  wget_and_untar https://github.com/apache/arrow/archive/apache-arrow-${ARROW_VERSION}.tar.gz arrow
+  cmake_install_dir arrow/cpp \
+    -DARROW_FLIGHT=ON \
+    -DARROW_BUILD_BENCHMARKS=ON \


Why do we need Arrow benchmarks?

Not sure, was there a reason @Rijin-N or @ashkrisk ?

Hi @BryanCutler @majetideepak,

This was included due to a known issue in Arrow version 15.0.0. Without setting ARROW_BUILD_BENCHMARKS=ON, a compilation error occurs while building the Arrow package with arrow flight. This issue has been fixed in later versions of Arrow.

Please see the PR link for details:
PR: https://github.com/apache/arrow/pull/41622/files

Thanks! Let's add a comment here about this so that this can be removed when Arrow is updated.

majetideepak · 2025-02-14T16:30:10Z

presto-native-execution/scripts/setup-adapters.sh

+}
+
+function install_arrow_flight {
+  ARROW_VERSION="15.0.0"


We should get this from the Velox script. We can skip here to align the versions.

@majetideepak the version is defined in the OS setup scripts, we could do something like

ARROW_VERSION="${ARROW_VERSION:-15.0.0}"

BryanCutler · 2025-02-17T18:56:55Z

@aditi-pandit @majetideepak I've addressed most of the feedback, just had a couple questions above. The connectors have been moved, namespaces cleaned and files named consistently. Please take another look, thanks!

The native Arrow Flight connector can be used to connect to any Arrow Flight enabled Data Source. The metadata layer is handled by the Presto coordinator and does not need to be re-implemented in C++. Any Java connector that inherits from `presto-base-arrow-flight` can use this connector as it's counterpart for the Prestissimo layer. Different Arrow-Flight enabled data sources can differ in authentication styles. A plugin-style interface is provided to handle such cases with custom authentication code by extending `arrow_flight::auth::Authenticator`. RFC: https://github.com/prestodb/rfcs/blob/main/RFC-0004-arrow-flight-connector.md#prestissimo-implementation Co-authored-by: Ashwin Kumar <[email protected]> Co-authored-by: Rijin-N <[email protected]> Co-authored-by: Nischay Yadav <[email protected]>

BryanCutler requested review from steveburnett and a team as code owners February 5, 2025 21:47

BryanCutler requested a review from jaystarshot February 5, 2025 21:47

prestodb-ci added the from:IBM PR from IBM label Feb 5, 2025

prestodb-ci requested review from a team, pdabre12 and psnv03 and removed request for a team February 5, 2025 21:47

BryanCutler force-pushed the arrow-connector-native-24082 branch from c9b9df2 to 2418e65 Compare February 5, 2025 21:50

steveburnett requested changes Feb 5, 2025

View reviewed changes

BryanCutler commented Feb 5, 2025

View reviewed changes

BryanCutler force-pushed the arrow-connector-native-24082 branch 2 times, most recently from f6eefb6 to 4b83c44 Compare February 5, 2025 22:12

steveburnett previously approved these changes Feb 5, 2025

View reviewed changes

BryanCutler commented Feb 5, 2025

View reviewed changes

BryanCutler mentioned this pull request Feb 6, 2025

[native] Add Arrow Flight Connector #24082

Open

6 tasks

BryanCutler dismissed steveburnett’s stale review via 49a3234 February 6, 2025 22:57

BryanCutler force-pushed the arrow-connector-native-24082 branch from 4b83c44 to 49a3234 Compare February 6, 2025 22:57

BryanCutler commented Feb 6, 2025

View reviewed changes

BryanCutler mentioned this pull request Feb 7, 2025

Make ArrowFlightConfig verifyServer true by default #24518

Merged

6 tasks

aditi-pandit reviewed Feb 12, 2025

View reviewed changes

majetideepak reviewed Feb 13, 2025

View reviewed changes

majetideepak reviewed Feb 14, 2025

View reviewed changes

BryanCutler force-pushed the arrow-connector-native-24082 branch 4 times, most recently from 92b5668 to cc96d0a Compare February 17, 2025 18:54

BryanCutler force-pushed the arrow-connector-native-24082 branch 3 times, most recently from 7043345 to 5a5a886 Compare February 17, 2025 22:22

BryanCutler requested review from aditi-pandit and majetideepak February 19, 2025 23:14

majetideepak and others added 2 commits February 20, 2025 14:49

[native] Pass extraCredentials to connector session properties

4775ae5

BryanCutler force-pushed the arrow-connector-native-24082 branch from 5a5a886 to 9aa8360 Compare February 20, 2025 23:18

	To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:
	To create the TLS certificates and keys inside the `tls_certs` folder, run the following command:


		namespace facebook::presto::connector {

		void registerAllPrestoConnectors() {


		std::unique_ptr<TestFlightServer> TestFlightServerTest::server;

		TEST_F(TestFlightServerTest, basicTest) {

[native] Add Apache Arrow Flight Connector #24504

Are you sure you want to change the base?

[native] Add Apache Arrow Flight Connector #24504

Conversation

BryanCutler commented Feb 5, 2025 • edited Loading

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

steveburnett commented Feb 5, 2025

BryanCutler commented Feb 5, 2025

steveburnett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

BryanCutler Feb 5, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashkrisk Feb 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elbinpallimalilibm Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aditi-pandit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BryanCutler Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ashkrisk Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rijin-N Feb 14, 2025 • edited Loading

Choose a reason for hiding this comment

BryanCutler commented Feb 5, 2025 •

edited

Loading

BryanCutler Feb 5, 2025 •

edited

Loading

ashkrisk Feb 12, 2025 •

edited

Loading

elbinpallimalilibm Feb 7, 2025 •

edited

Loading

BryanCutler Feb 14, 2025 •

edited

Loading

ashkrisk Feb 14, 2025 •

edited

Loading

Rijin-N Feb 14, 2025 •

edited

Loading