Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Catalog Loading Forward Fit #24587

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

infvg
Copy link
Contributor

@infvg infvg commented Feb 18, 2025

Description

Added endpoints to dynamically load catalogs without an engine restart

Motivation and Context

Previously, catalogs would only be loaded while the engine is starting.

Impact

New APIs added:

curl -X POST http://localhost:8001/v1/catalog/tpch_1 \
     -H "X-Presto-Prefix-Url: PREFIX" \
     -H "X-Presto-User: PRESTO_USER" \
     -H "User-Agent: StatementClient/0.55-SNAPSHOT" \
     -H "Content-Type: application/json" \
     -d '{
           "connector.name": "tpch",
           "tpch.splits-per-node": "4"
         }'
curl -v -X GET http://localhost:8001/v1/catalog \
     -H "X-Presto-Prefix-Url: PREFIX" \
     -H "X-Presto-User: PRESTO_USER" \
     -H "User-Agent: StatementClient/0.55-SNAPSHOT" \
     -H "Content-Type: application/json" 
curl -v -X GET http://localhost:8080/v1/catalog/system/status \
     -H "X-Presto-Prefix-Url: PREFIX" \
     -H "X-Presto-User: PRESTO_USER" \
     -H "User-Agent: StatementClient/0.55-SNAPSHOT" \
     -H "Content-Type: application/json"
curl -v -X DELETE http://localhost:8080/v1/catalog/tpch_1 \
     -H "X-Presto-Prefix-Url: PREFIX" \
     -H "X-Presto-User: PRESTO_USER" \
     -H "User-Agent: StatementClient/0.55-SNAPSHOT" \
     -H "Content-Type: application/json"
curl -X PUT http://localhost:8080/v1/catalog/tpch_1 \
     -H "X-Presto-Prefix-Url: PREFIX" \
     -H "X-Presto-User: PRESTO_USER" \
     -H "User-Agent: StatementClient/0.55-SNAPSHOT" \
     -H "Content-Type: application/json" \
     -d '{
           "connector.name": "tpch",
           "tpch.splits-per-node": "4"
         }'

Test Plan

Added test cases

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add endpoints that can dynamically load catalogs

Hive Connector Changes
* Fix for configurations leaks using class loader isolation for Hive connector instances

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 18, 2025
@infvg infvg force-pushed the dynamic-forward-fit branch from e08829b to 8ebd2b6 Compare February 18, 2025 11:33
@infvg infvg changed the title Fix for configurations leaks using class loader isolation for Hive co… Dynamic Catalog Loading Forward Fit Feb 18, 2025
@infvg infvg force-pushed the dynamic-forward-fit branch 3 times, most recently from 32124f4 to 0211437 Compare February 19, 2025 09:50
@infvg infvg marked this pull request as ready for review February 19, 2025 09:50
@infvg infvg requested a review from presto-oss February 19, 2025 09:50
steveburnett
steveburnett previously approved these changes Feb 19, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Looks good. Some nits of punctuation and phrasing suggestions for consistency.

@infvg infvg force-pushed the dynamic-forward-fit branch from 0211437 to 9a945cf Compare February 19, 2025 15:17
If implemented, this will add endpoints that allow catalogs to be added without
restarting the presto engine.

Co-authored-by: Anoop V S <[email protected]>
Co-authored-by: Deepa George <[email protected]>
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

@ethanyzhang ethanyzhang requested a review from aaneja February 19, 2025 20:26
@ethanyzhang
Copy link
Contributor

@aaneja This may have some similar issues like the internal open lineage changes, can you help take a first pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants