Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add documentation to note "-gb" Prestissimo Configs are using GiB units and not gB units #24607

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

minhancao
Copy link
Contributor

@minhancao minhancao commented Feb 21, 2025

Description

Add documentation to note "-gb" Prestissimo Configs are using GiB units and not gB units

Motivation and Context

Resolves #24125
"-gb" Prestissimo configs like system-memory-gb are actually using GiB units and not gB units. This documentation will help clarify any confusion from users.

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Documentation
* Add documentation to note "-gb" Prestissimo Configs are using GiB units and not gB units.

@minhancao minhancao self-assigned this Feb 21, 2025
@minhancao minhancao requested review from steveburnett, elharo and a team as code owners February 21, 2025 19:30
@minhancao minhancao requested a review from presto-oss February 21, 2025 19:30
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 21, 2025
@prestodb-ci prestodb-ci requested review from a team, infvg and pratyakshsharma and removed request for a team February 21, 2025 19:30
@github-actions github-actions bot added the docs label Feb 21, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! One question about the value.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks for adding this to the doc!

@steveburnett steveburnett merged commit 95dc155 into prestodb:master Feb 21, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs from:IBM PR from IBM
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Size related memory configurations use GiB instead of GB
3 participants