Add github action to release tempto #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unidevel
force-pushed
the
add_release_action
branch
from
41c1ff2 to
94fb52b
Compare
aaneja
approved these changes
Feb 7, 2025
ZacBlanco
reviewed
Feb 10, 2025
| major=$(echo $release_version | cut -d. -f1) | ||
| minor=$(echo $release_version | cut -d. -f2) | ||
| # Increment the minor version | ||
| last_minor=$((minor - 1)) |
There was a problem hiding this comment.
what happens here if minor == 0? e.g. assume we release a 2.0
There was a problem hiding this comment.
Thanks, seems I need a new parameter and flag for this, I'll update later.
There was a problem hiding this comment.
I don't think you need to add a flag -- the likelihood that we ever end up releasing anything other than 0.x is low. However, I think it would be good to add a check and just error out here with a message saying that the pipeline doesn't handle a new major version
There was a problem hiding this comment.
updated @ZacBlanco
ZacBlanco
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is sitll in progress.
Testing action in this repo => https://github.com/unix280/tempto/actions/workflows/release.yml
Test passed with test GPG key and test maven repo => https://github.com/unix280/tempto/actions/runs/13102076676
Environment setup:
releasereleaseenvironment settings