Include sources and javadoc jars #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacBlanco
approved these changes
Feb 21, 2025
build.gradle
Outdated
| @@ -113,7 +113,7 @@ ext.tempto_runner = project(':tempto-runner') | |||
| ext.tempto_ldap = project(':tempto-ldap') | |||
| ext.tempto_kafka = project(':tempto-kafka') | |||
| ext.expected_result_generator = project(':expected-result-generator') | |||
| ext.tempto_version = '1.55-SNAPSHOT' | |||
| ext.tempto_version = '1.54-SNAPSHOT' | |||
There was a problem hiding this comment.
Are we intending to roll back the commits on master to fix this? Or just attempt the action again & re-tagging? We probably need to delete the git tag before retrying
There was a problem hiding this comment.
We should republish 1.54 since it was not released past staging. I thought re-tagging would occur with the action as well. If not, lets manually delete the release tag for 1.54 @unidevel
I am open to suggestions for best practices here
unidevel
reviewed
Feb 21, 2025
unidevel
approved these changes
Feb 21, 2025
unidevel
reviewed
Feb 21, 2025
aaneja
force-pushed
the
includeSourceJavadocJars
branch
from
193ac1b to
444196f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for publishing to Sonatype