Skip to content

Commit

Permalink
chore(housekeeping): update ESLint to v9 (#709)
Browse files Browse the repository at this point in the history
Co-authored-by: JounQin <[email protected]>
  • Loading branch information
fisker and JounQin authored Mar 9, 2025
1 parent 9726349 commit 6f35f1b
Show file tree
Hide file tree
Showing 13 changed files with 1,838 additions and 1,638 deletions.
24 changes: 20 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,29 @@ on:
- main
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
ci:
name: Lint and Test on Node ${{ matrix.node-version }}
name: Lint and Test on Node ${{ matrix.node-version }} (ESLint ${{ matrix.eslint-version }})
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 22
- 20
- 18
eslint-version:
- 9
- 8
include:
- node-version: 16
eslint-version: 8
- node-version: 14
eslint-version: 8

steps:
- uses: actions/checkout@v4
Expand All @@ -32,6 +44,10 @@ jobs:
- name: Install
run: pnpm install

- name: Install ESLint ${{ matrix.node-version }}
if: ${{ matrix.eslint-version != 9 }}
run: pnpm install -D eslint@${{ matrix.eslint-version }} eslint-plugin-svelte@2 svelte@3

- name: Test
run: pnpm mocha

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
5 changes: 0 additions & 5 deletions .remarkrc

This file was deleted.

5 changes: 5 additions & 0 deletions .remarkrc.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import preset from '@1stg/remark-preset';

export default {
plugins: [preset],
};
1 change: 1 addition & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ module.exports = [
eslintPluginMdx.flat,
eslintPluginMdx.flatCodeBlocks,
eslintPluginPrettierRecommended,
{ files: ['**/*.mjs'], languageOptions: { sourceType: 'module' } },
{
rules: {
'eslint-plugin/report-message-format': ['error', '^[^a-z].*\\.$'],
Expand Down
24 changes: 11 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,45 +67,43 @@
"synckit": "^0.9.1"
},
"devDependencies": {
"@1stg/remark-preset": "^2.0.0",
"@1stg/remark-preset": "^3.0.0",
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.1",
"@commitlint/config-conventional": "^18.4.3",
"@eslint-community/eslint-plugin-eslint-comments": "^4.4.1",
"@eslint/js": "^8.56.0",
"@eslint/js": "^9.21.0",
"@graphql-eslint/eslint-plugin": "^3.20.1",
"@html-eslint/parser": "^0.24.1",
"@prettier/plugin-pug": "^3.0.0",
"@types/eslint": "^8.56.0",
"@types/prettier-linter-helpers": "^1.0.4",
"commitlint": "^18.4.3",
"eslint": "^8.56.0",
"eslint-config-prettier": "^9.1.0",
"eslint": "^9.21.0",
"eslint-config-prettier": "^10.1.1",
"eslint-formatter-friendly": "^7.0.0",
"eslint-mdx": "^2.3.0",
"eslint-mdx": "^3.1.5",
"eslint-plugin-eslint-plugin": "^5.2.1",
"eslint-plugin-mdx": "^2.3.0",
"eslint-plugin-mdx": "^3.2.0",
"eslint-plugin-n": "^16.5.0",
"eslint-plugin-prettier": "link:.",
"eslint-plugin-pug": "^1.2.5",
"eslint-plugin-svelte": "^2.35.1",
"eslint-plugin-svelte3": "^4.0.0",
"eslint-plugin-svelte": "^3.0.2",
"graphql": "^16.8.1",
"lint-staged": "^15.2.0",
"mocha": "^10.2.0",
"prettier": "^3.1.1",
"prettier": "^3.5.3",
"prettier-plugin-pkg": "^0.18.0",
"prettier-plugin-svelte": "^3.1.2",
"simple-git-hooks": "^2.9.0",
"svelte": "^4.2.8",
"svelte": "^5.20.5",
"vue-eslint-parser": "^9.3.2"
},
"pnpm": {
"patchedDependencies": {
"@types/[email protected]": "patches/@[email protected].patch"
"[email protected]": "patches/[email protected].patch"
},
"overrides": {
"prettier": "^3.1.1"
"prettier": "^3.5.3"
}
}
}
14 changes: 0 additions & 14 deletions patches/@[email protected]

This file was deleted.

52 changes: 52 additions & 0 deletions patches/[email protected]
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
diff --git a/lib/configuration.js b/lib/configuration.js
index 77f3969c1c583c5869f636076c15892d7f2da18f..48b3df03392ab1aafb5e714f39c015e2633ee0e2 100644
--- a/lib/configuration.js
+++ b/lib/configuration.js
@@ -78,7 +78,7 @@
* Shared settings for parsers and compilers (optional).
*/

-import assert from 'node:assert/strict'
+import assert from 'node:assert'
import path from 'node:path'
import {fileURLToPath, pathToFileURL} from 'node:url'
import extend from 'extend'
diff --git a/lib/file-pipeline/stringify.js b/lib/file-pipeline/stringify.js
index d5e4e0d6d59ba76d72dc394b42e6e890a5d5e48e..01f0cf74a806ba17047b5e7f1587671cce38bbe5 100644
--- a/lib/file-pipeline/stringify.js
+++ b/lib/file-pipeline/stringify.js
@@ -3,7 +3,7 @@
* @import {Context} from './index.js'
*/

-import assert from 'node:assert/strict'
+import assert from 'node:assert'
import createDebug from 'debug'
import {inspectColor, inspectNoColor} from 'unist-util-inspect'
import {statistics} from 'vfile-statistics'
diff --git a/lib/file-pipeline/transform.js b/lib/file-pipeline/transform.js
index a80702c25b5c6f6ffff52829a7bf98fe5f87cb3d..d6489b46bc5a113a14cfa4ab12c9a7aca1a777ea 100644
--- a/lib/file-pipeline/transform.js
+++ b/lib/file-pipeline/transform.js
@@ -4,7 +4,7 @@
* @import {Context} from './index.js'
*/

-import assert from 'node:assert/strict'
+import assert from 'node:assert'
import createDebug from 'debug'
import {statistics} from 'vfile-statistics'

diff --git a/lib/find-up.js b/lib/find-up.js
index 81623700c8b53572ca7b0dd3e6d7c239b027d50c..9ff6176124f26f028c20d9142184e16cd8a5357d 100644
--- a/lib/find-up.js
+++ b/lib/find-up.js
@@ -48,7 +48,7 @@
* Turn a found file into a value.
*/

-import assert from 'node:assert/strict'
+import assert from 'node:assert'
import fs from 'node:fs'
import path from 'node:path'
import {fileURLToPath} from 'node:url'
Loading

0 comments on commit 6f35f1b

Please sign in to comment.