[CARE-6230] Feature - Store integrationRunUuid in coverage entry#322
Merged
yuriyyakym merged 2 commits intomasterfrom Sep 18, 2024
Merged
Conversation
marko-ogg
reviewed
Sep 18, 2024
src/endpoints/Coverage/types.ts
Outdated
|
|
||
| export interface CreateRequest extends UpdateRequest {} | ||
| export interface CreateRequest extends UpdateRequest { | ||
| integrationRunUuid?: CoverageIntegrationRun['uuid'] | null; |
Contributor
There was a problem hiding this comment.
I would rename it:
integration_run?: CoverageIntegrationRun['id'] | CoverageIntegrationRun['uuid'] | null;
Note that we use snake case in the API.
yuriyyakym
deleted the
feature/store-integration-run-id-in-coverage-entry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marko-ogg please implement related property on back-end side. Also let me know if the property should be renamed.
I've noticed that we have both
idanduuidprops in integration run entry, so I am unsure if I've chosen the correct one for referencing (uuid).