Skip to content

[feature] 외부 API(결제) 트랜잭션 분리 / 락 도입 / 구독 양방향 매핑 제거 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kimeunkyoungg merged 16 commits into from
Nov 18, 2025
Merged

[feature] 외부 API(결제) 트랜잭션 분리 / 락 도입 / 구독 양방향 매핑 제거 #51

kimeunkyoungg merged 16 commits into from
Nov 18, 2025

Conversation

@kimeunkyoungg
Copy link
Collaborator

@kimeunkyoungg kimeunkyoungg commented Nov 18, 2025 •
edited
Loading

📝 작업 개요

  • 2차 피드백 반영 수정

🔗 관련 이슈

🔍 작업 내용

  • 토스페이먼츠 API 와 트랜잭션 분리 -> 퍼사드 패턴으로 구현
  • 결제, 랭킹 동시성 고려하여 락 도입
  • 결제는 비관적 락 사용
  • 랭킹은 Redisson 분산락 사용
  • 구독 양방향 제거
  • 랭킹 진행률 바 오류 수정
  • 랭킹 동점자 닉네임 순으로 정렬

✅ 체크리스트

  • 코드에 오류가 없음
  • 테스트 코드 작성/수행 완료
  • 팀 내 코드 스타일 가이드 준수
  • 이슈 연결 여부

@kimeunkyoungg kimeunkyoungg self-assigned this Nov 18, 2025
larama-C
larama-C approved these changes Nov 18, 2025
View reviewed changes
Copy link
Collaborator

@larama-C larama-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

myoungjinseo
myoungjinseo approved these changes Nov 18, 2025
View reviewed changes
backend/src/main/java/com/backend/api/payment/service/PaymentService.kt
.bodyToMono(PaymentConfirmResponse::class.java)
.block()
?: throw ErrorException(ErrorCode.PAYMENT_APPROVE_FAILED)
fun createPayment(response: PaymentConfirmResponse, user: User): Payment {
Copy link
Member

@myoungjinseo myoungjinseo Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

트랜잭션이 빠져있습니다.

@kimeunkyoungg kimeunkyoungg merged commit 3aaf399 into main Nov 18, 2025
1 check failed
@kimeunkyoungg kimeunkyoungg deleted the feature/#47 branch November 18, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larama-C larama-C larama-C approved these changes

@myoungjinseo myoungjinseo myoungjinseo approved these changes

Assignees

@kimeunkyoungg kimeunkyoungg

Labels

feature refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feature] 외부 API(결제) 트랜잭션 분리 / 락 도입

4 participants

@kimeunkyoungg @larama-C @myoungjinseo