[4기 원건희] Springboot-jpa weekly 미션 1차 PR입니다. #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojinyou
reviewed
Jul 30, 2023
src/main/java/com/jpaweekily/domain/customer/CustomerMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jpaweekily/domain/customer/application/CustomerServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jpaweekily/domain/customer/application/CustomerService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jpaweekily/domain/order/application/OrderServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jpaweekily/domain/order/application/OrderServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jpaweekily/domain/user/application/UserServiceImpl.java
Outdated
Show resolved
Hide resolved
src/test/java/com/jpaweekily/domain/customer/application/CustomerServiceImplTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/jpaweekily/domain/customer/application/CustomerServiceImplTest.java
Outdated
Show resolved
Hide resolved
seung-hun-h
suggested changes
Jul 31, 2023
pom.xml
Outdated
There was a problem hiding this comment.
메이븐을 사용하시는 이유가 있나요??
사용하면 안되는 것은 아니지만 최근에는 그레들로 많이들 옮겨가는 추세라서요. 처음 개발을 배우는 입장에서 메이븐 보다는 그레들이 낫지 않을까 하는 입장입니다.
혹시 사용하시는 이유가 있는지 궁금하네요~
There was a problem hiding this comment.
이전에 실무에서 메이븐을 더 많이 쓴다라는 이야기를 들어서 메이븐이 익숙해지려고 사용해보았습니다! 그레들로 다시 넘어가는 추세였군요!
Comment on lines
27
to
33
| public void changeFirstName(String firstName) { | ||
| this.firstName = firstName; | ||
| } | ||
|
|
||
| public void changeLastName(String lastName) { | ||
| this.lastName = lastName; | ||
| } |
There was a problem hiding this comment.
이렇게 되면 setter와 크게 다르지 않은 메서드인 것 같아요.
변경 되는 메서드를 하나로 만들어줘도 괜찮을 것 같습니다
Comment on lines
26
to
36
| @GetMapping | ||
| public ResponseEntity<List<CustomerResponse>> customerList() { | ||
| List<CustomerResponse> customers = customerService.findCustomers(); | ||
| return ResponseEntity.ok(customers); | ||
| } | ||
|
|
||
| @GetMapping("/page") | ||
| public ResponseEntity<Page<CustomerResponse>> customerPage(@PageableDefault() Pageable pageable) { | ||
| Page<CustomerResponse> customers = customerService.findCustomersWithPaging(pageable); | ||
| return ResponseEntity.ok(customers); | ||
| } |
There was a problem hiding this comment.
이 부분은 페이지네이션을 사용하는 api로 통일하는 것이 좋겠네요
src/main/java/com/jpaweekily/domain/customer/presentation/CustomerApiController.java
Outdated
Show resolved
Hide resolved
| this.orderProductRepository = orderProductRepository; | ||
| } | ||
|
|
||
| public Long createOrder(OrderCreateRequest request) { |
| private UserService userService; | ||
|
|
||
| @Test | ||
| void order_create_test() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
👩💻 구현 내용 & 구현 예정
페어 프로그래밍을 진행하면서 상대적으로 보완해야할 점이 많다고 생각하여 단순히 연관관계 매핑을 실습하는 것 보다는 주어진 entity들을 활용하여 기초적인 스프링 프로젝트를 만들어보는 쪽으로 진행할 계획입니다.
CRUD 중 모든 엔티티의 Create 부분의 구현과 테스트를 완료하였습니다.
도메인 로직들을 구현할 예정입니다. (주문 상태 변경, 유저 정보 변경 등)
C를 제외한 RUD를 구현할 예정입니다.
RestController를 구현할 예정입니다.