Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] #109 API 세팅 #117

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Conversation

shlee9999
Copy link
Collaborator

@shlee9999 shlee9999 commented Dec 3, 2024

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #109

API 관련 공통 prop들을 세팅했습니다. 마우스 호버 시 미리보기가 제공되어 편하게 개발할 수 있습니다.
Pick을 사용하여 CommonAPIRequest, CommonAPIResponse에서 뽑아 쓰시길 바랍니다

🖼️ Screenshots

{B3E0DA98-46AD-4B4C-88C8-0554AF9E405A}

@shlee9999 shlee9999 linked an issue Dec 3, 2024 that may be closed by this pull request
@shlee9999 shlee9999 changed the title [Feature] API 세팅 [Feature] #109 API 세팅 Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

⚡ Lighthouse Reports

http://localhost:4173/

Performance Metrics

Category Score
Performance 🟠 85
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.0 s
Largest Contentful Paint 🔴 4.1 s
Total Blocking Time 🟢 30 ms
Cumulative Layout Shift 🟢 0.004
Speed Index 🟢 2.0 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/log

Performance Metrics

Category Score
Performance 🟠 85
Accessibility 🟢 95
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 1.9 s
Largest Contentful Paint 🔴 4.1 s
Total Blocking Time 🟢 20 ms
Cumulative Layout Shift 🟢 0.003
Speed Index 🟢 1.9 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/login

Performance Metrics

Category Score
Performance 🟠 86
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.6 s
Largest Contentful Paint 🟠 3.7 s
Total Blocking Time 🟢 0 ms
Cumulative Layout Shift 🟢 0.004
Speed Index 🟢 2.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/mypage

Performance Metrics

Category Score
Performance 🟠 82
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 1.9 s
Largest Contentful Paint 🔴 4.7 s
Total Blocking Time 🟢 20 ms
Cumulative Layout Shift 🟢 0.001
Speed Index 🟢 1.9 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

ruehan
ruehan previously approved these changes Dec 3, 2024
kimjuyoung78
kimjuyoung78 previously approved these changes Dec 3, 2024
@shlee9999 shlee9999 closed this Dec 3, 2024
@shlee9999 shlee9999 merged commit 3c2c8ce into develop Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] API 관련 세팅
3 participants