Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 feature/GitHub action lighthouse #3

Merged
merged 30 commits into from
Nov 18, 2024
Merged

Conversation

shlee9999
Copy link
Collaborator

@shlee9999 shlee9999 commented Nov 16, 2024

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #2

github action lighthouse를 적용하였습니다.
댓글에 점수가 표시됩니다.
현재 점수가 매우 낮게 나와 assert는 우선 주석 처리 했으며, 원인 파악이 필요합니다.

🖼️ Screenshots

{0AE81D9E-2D80-4CFC-AD9C-B245AAE6CBCE}

@shlee9999 shlee9999 linked an issue Nov 16, 2024 that may be closed by this pull request
@shlee9999 shlee9999 force-pushed the 2-feature/github-action-lighthouse branch 2 times, most recently from 4cd27e2 to 1cf38a9 Compare November 16, 2024 03:55
@shlee9999 shlee9999 force-pushed the 2-feature/github-action-lighthouse branch from 1cf38a9 to a28078f Compare November 16, 2024 04:00
@shlee9999 shlee9999 force-pushed the 2-feature/github-action-lighthouse branch 2 times, most recently from 2422ca4 to f2dc630 Compare November 16, 2024 07:59
@shlee9999 shlee9999 force-pushed the 2-feature/github-action-lighthouse branch from 0dc3be2 to b4c2caa Compare November 16, 2024 08:30
@shlee9999 shlee9999 force-pushed the 2-feature/github-action-lighthouse branch from 94054b6 to 9371f28 Compare November 17, 2024 06:02
@shlee9999 shlee9999 force-pushed the 2-feature/github-action-lighthouse branch from 9371f28 to 60173a4 Compare November 17, 2024 06:10
@shlee9999 shlee9999 force-pushed the 2-feature/github-action-lighthouse branch 2 times, most recently from f699a1a to 1a8186a Compare November 17, 2024 15:47
Copy link

⚡ Lighthouse Report

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best Practices 100
🟢 SEO 100

Detailed Metrics

Metric Value
🟢 First Contentful Paint 1.5 s
🟢 Largest Contentful Paint 2.0 s
🟢 Total Blocking Time 0 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 1.5 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@shlee9999 shlee9999 self-assigned this Nov 18, 2024
@shlee9999 shlee9999 requested review from ruehan and wonill November 18, 2024 03:40
@wonill wonill merged commit 6f802ee into main Nov 18, 2024
1 check passed
@github-actions github-actions bot deleted the 2-feature/github-action-lighthouse branch November 26, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Github Action lighthouse 적용
3 participants