Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Design: 강아지 ν”„λ‘œν•„ 기본정보 μž…λ ₯νŽ˜μ΄μ§€ μΆ”κ°€ #62

Merged
merged 3 commits into from
Nov 21, 2024
Merged

🎨 Design: 강아지 ν”„λ‘œν•„ 기본정보 μž…λ ₯νŽ˜μ΄μ§€ μΆ”κ°€ #62

merged 3 commits into from
Nov 21, 2024

Conversation

wonill
Copy link
Collaborator

@wonill wonill commented Nov 21, 2024 •
edited
Loading

βœ… PR Checklist

  • λΆˆν•„μš”ν•œ μ½”λ“œ 쀑볡이 μ—†μŠ΅λ‹ˆλ‹€.
  • λ―Όκ°ν•œ 정보λ₯Ό ν¬ν•¨ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.
  • λΆˆν•„μš”ν•œ μ½˜μ†” λ‘œκ·Έλ‚˜ 주석을 ν¬ν•¨ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.
  • μ»΄ν¬λ„ŒνŠΈ key값에 κ³ μœ ν•œ 값을 ν• λ‹Ήν–ˆμŠ΅λ‹ˆλ‹€.

πŸ“ Summary

πŸ”— ISSUE : 32

강아지 ν”„λ‘œν•„ 기본정보 μž…λ ₯νŽ˜μ΄μ§€ UI μž‘μ—…ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ–ΌοΈ Screenshots

image

@wonill wonill linked an issue Nov 21, 2024 that may be closed by this pull request
[Design] 반렀견 기본정보 μž…λ ₯νŽ˜μ΄μ§€ #32
Closed
@github-actions github-actions bot requested review from ruehan and shlee9999 November 21, 2024 09:30
@github-actions GitHub Actions
Copy link

⚑ Lighthouse Report

Category Score
🟒 Performance 94
🟒 Accessibility 100
🟒 Best Practices 100
🟒 SEO 100

Detailed Metrics

Metric Value
🟒 First Contentful Paint 1.6 s
🟠 Largest Contentful Paint 2.9 s
🟒 Total Blocking Time 0 ms
🟒 Cumulative Layout Shift 0
🟒 Speed Index 1.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@wonill wonill force-pushed the 32-design/add-dog-profile-ui branch from 417694d to 12416e4 Compare November 21, 2024 09:52
@wonill wonill enabled auto-merge November 21, 2024 10:43
@wonill wonill merged commit 0627a3a into develop Nov 21, 2024
1 check passed
@github-actions github-actions bot deleted the 32-design/add-dog-profile-ui branch November 29, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruehan ruehan ruehan approved these changes

@shlee9999 shlee9999 shlee9999 approved these changes

Assignees

@wonill wonill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] 반렀견 기본정보 μž…λ ₯νŽ˜μ΄μ§€
3 participants
@wonill @ruehan @shlee9999