Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] #6 mac snippet 수정 및 스니펫 개선 #7

Merged
merged 1 commit into from
Nov 21, 2024
Merged

[Bug] #6 mac snippet 수정 및 스니펫 개선 #7

merged 1 commit into from
Nov 21, 2024

Conversation

shlee9999
Copy link
Collaborator

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #6

🖼️ Screenshots

@shlee9999 shlee9999 linked an issue Nov 18, 2024 that may be closed by this pull request
[BUG] Mac용 스니펫이 코드 컨벤션과 맞지 않음 #6
Closed
@github-actions GitHub Actions
Copy link

⚡ Lighthouse Report

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best Practices 100
🟢 SEO 100

Detailed Metrics

Metric Value
🟢 First Contentful Paint 1.5 s
🟢 Largest Contentful Paint 2.0 s
🟢 Total Blocking Time 10 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 1.5 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@shlee9999 shlee9999 self-assigned this Nov 18, 2024
@shlee9999 shlee9999 closed this Nov 19, 2024
@shlee9999 shlee9999 reopened this Nov 19, 2024
@shlee9999 shlee9999 enabled auto-merge November 20, 2024 00:18
@shlee9999 shlee9999 merged commit 4447bbf into develop Nov 21, 2024
4 checks passed
@github-actions github-actions bot deleted the 6-bug/mac-snippets branch November 26, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruehan ruehan ruehan approved these changes

@kimjuyoung78 kimjuyoung78 kimjuyoung78 approved these changes

@wonill wonill Awaiting requested review from wonill

Assignees

@shlee9999 shlee9999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Mac용 스니펫이 코드 컨벤션과 맞지 않음
3 participants
@shlee9999 @ruehan @kimjuyoung78