Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discussion
I need to profile and optimize the access of variable container. Due to frequent look-ups, it's essential to measure the performance difference between
std::map
,std::unordered_map
, andstd::vector
.Todo
Patterns::Selection
equations.cc
andvariableContainer
to prevent the calculated of quad point location. This could be a compile time flag or something. This is worth looking into because there is a decent amount of time spent calculating the quadrature point locations (~5%).type_enums