Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Feat/#1752 fix witness generation - json exportor#1789

Open
KimiWu123 wants to merge 62 commits intomainfrom
feat/#1752-fix-witness-generation-json-export
Open

Feat/#1752 fix witness generation - json exportor#1789
KimiWu123 wants to merge 62 commits intomainfrom
feat/#1752-fix-witness-generation-json-export

Conversation

@KimiWu123
Copy link
Copy Markdown
Contributor

@KimiWu123 KimiWu123 commented Mar 8, 2024 •
edited
Loading

Description

closed #1752

Issue Link

#1752

Type of change

  • New feature (non-breaking change which adds functionality)

Contents

  • This PR merged .go files of Extension into branch #1756.
  • Have a new function, GenerateWitness to export json for stack trie.
  • Add isTxProof flag in equipLeafWithModExtensionNode and `addBranchAndPlaceholder' to avoid touching the exising logic of the state trie.
  • Fix GetProof(): before this fix, if any hashed nodes in the proof, other non-hashed nodes will not append to the proof. This causes the output proofs are incorrect.
  • Add nibbles and proof type in StackProof for exporting json files.
  • Modified extension node is not included in this PR, will do it in futher PR. Stack trie witness generator - modified extension node #1809

@github-actions github-actions bot added the crate-geth-utils Issues related to the geth-utils workspace member label Mar 8, 2024
@KimiWu123 KimiWu123 mentioned this pull request Mar 8, 2024
Open
@KimiWu123 KimiWu123 force-pushed the feat/#1752-fix-witness-generation-json-export branch from 400dca8 to 799a02d Compare March 20, 2024 06:19
@KimiWu123 KimiWu123 self-assigned this Mar 31, 2024
@KimiWu123 KimiWu123 force-pushed the feat/#1752-fix-witness-generation-json-export branch from 08778eb to 394211a Compare March 31, 2024 09:54
@KimiWu123 KimiWu123 force-pushed the feat/#1752-fix-witness-generation-json-export branch from 47ff445 to ba8df43 Compare April 16, 2024 08:21
@KimiWu123 KimiWu123 force-pushed the feat/#1752-fix-witness-generation-json-export branch from ba8df43 to e5c7559 Compare April 16, 2024 08:30
@KimiWu123 KimiWu123 force-pushed the feat/#1752-fix-witness-generation-json-export branch from f8e266f to 9b0eb3f Compare April 16, 2024 08:49
@KimiWu123 KimiWu123 requested a review from miha-stopar April 16, 2024 08:59
@KimiWu123 KimiWu123 marked this pull request as ready for review April 16, 2024 08:59
@KimiWu123 KimiWu123 changed the title [WIP] Feat/#1752 fix witness generation - json exportor Feat/#1752 fix witness generation - json exportor Apr 16, 2024
@github-actions github-actions bot added the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Apr 18, 2024
@KimiWu123 KimiWu123 force-pushed the feat/#1752-fix-witness-generation-json-export branch 2 times, most recently from d641299 to 4fff94d Compare April 19, 2024 07:12
@KimiWu123 KimiWu123 force-pushed the feat/#1752-fix-witness-generation-json-export branch from 4fff94d to 3e90dda Compare April 19, 2024 07:27
@KimiWu123
Copy link
Copy Markdown
Contributor Author

KimiWu123 commented Apr 19, 2024

Hi @miha-stopar, I merged #1756, but only .go files, and now everything works, all the tests were passed! It' ready for review .

@KimiWu123 KimiWu123 mentioned this pull request Apr 23, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@miha-stopar miha-stopar Awaiting requested review from miha-stopar

At least 2 approving reviews are required to merge this pull request.

Assignees

@KimiWu123 KimiWu123

Labels

crate-geth-utils Issues related to the geth-utils workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MPT - stack trie] fix witness generation

2 participants

@KimiWu123 @miha-stopar