Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Upgrade rust version #1769

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Upgrade rust version #1769

merged 7 commits into from
Feb 16, 2024

Conversation

ChihChengLiang
Copy link
Collaborator

Description

We've been using the version one year ago. Let's get a new year vibe.

Issue Link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor (no updates to logic)

Contents

Major clippy fix

  • Clippy now detect useless vector. It is a little bit buggy, and it sometimes complains without giving the exact line.

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member crate-eth-types Issues related to the eth-types workspace member crate-geth-utils Issues related to the geth-utils workspace member labels Feb 15, 2024
Copy link
Member

@curryrasul curryrasul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zemse zemse added this pull request to the merge queue Feb 16, 2024
Merged via the queue into main with commit db0d403 Feb 16, 2024
13 checks passed
@zemse zemse deleted the upgrade-rust-version branch February 16, 2024 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-eth-types Issues related to the eth-types workspace member crate-geth-utils Issues related to the geth-utils workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants