-
Notifications
You must be signed in to change notification settings - Fork 854
Refactor: use StepRws in evm circuits to replace rw indices #1786
Refactor: use StepRws in evm circuits to replace rw indices #1786
Conversation
ff650a3
to
86adab3
Compare
@ChihChengLiang this should be ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just two nitpicks.
Thanks for the review @miha-stopar ! I've made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maschad Great work replacing the manual counting of read-write indices with the automatic one. The assignment looks cleaner now.
I added some comments on fixing the APIs and some style fixes. We can merge the PR after the feedback are addressed.
zkevm-circuits/src/evm_circuit/execution/error_oog_memory_copy.rs
Outdated
Show resolved
Hide resolved
Thanks for your review @ChihChengLiang I've made the requested adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix
Description
Continuing the work originally started in #1616 this PR seeks to introduce
StepRws
across the evm circuits to reduce the need for tracking rw indices through code.Issue Link
Closes #1586
Type of change
Refactor (no updates to logic)
Contents
The change has been made to the following files