Multithreaded advice commitment and benchmark

[diazeddy]

Description

It completes a multithreaded implementation for computing and committing advice polynomials during proof generation in Hope of optimizing the process by using multiple CPU cores when they are available.

Key Features:

• Implemented multithreaded advice commitment: Modified the existing Halo2 codebase to compute advice commitments in parallel on multithreaded CPUs.
• Added benchmarking for advice commitment: Introduced indicative benchmark tests using the Criterion crate to compare the performance improvements of the multithreaded implementation against the original single-threaded implementation.

Issue Link

[link issue here]

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Refactor (no updates to logic)

Contents

• [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]

---

How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsibility

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

• What types of design choices did you face?
• What decisions you have made?
• Any valuable information that could help reviewers to think critically

[ed255]

Hi @diazeddy

I'm quite confused about this PR. What does this PR have to do with this repository? Why do you add a benchmark for commitments here?

[ed255]

Closing this PR because it doesn't make any sense.