This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Feat/Blob 4844 Pi Circuit Chunk Txbytes Condense #1796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix soundness bug in ecdsa circuit * update parameters * fix: ec_sub_unequal would have panicked for some edge cases (#999) * update ecdsa parameters --------- Co-authored-by: Rohit Narurkar <[email protected]>
* chore: recover_pk with k256 * chore: remove libsecp256k1 dep * chore: cargo lock file
* fix typos README.md * fix typo README.md * fix typos Bytecode_Circuit.md * fix typo EVM_Circuit.md * fix typo Keccak_Circuit.md
* refactoring of bus-mapping and adding input/return rlc fields to state gadgets * fix everything except OOG cases * fix: oog cases handled * standardize approach for base precompile as well
* patch for L2 node rpc * constrain max_txs to pass pi circuit * revert get access set to the same implement as upstream * update for using prestateTracer for state * fix coinbase issue * apply mock fill root * better form for mock filling mpt * dep issue * some trivial optimizations * grep mpt standlone circuit from test * update poseidon row params * fix issues in old_root setting * update ethblock for some fields * update more fields * update keccak inputs * update prev state root * update more fields for state root * update code size * fix storage issue on missing field * optimize the pre state handling * induce relax mode to raise some restrict * picking coinbase/difficulity from block instead of default constants * custom diff/coinbase in padding * fix the max_txs issue in pi_circuit * clippy and fmt * support single tx test * adjust params * rebuild mpt state in mock tx proven * fmt * resume some fields in prestate trace * test creating supercircuit from dummy witness block * revert most params * mitigate an issue in prestate tracer * add timeout spec for robust API call * fmt * add readme for test * add more comment according to review --------- Co-authored-by: Steven <[email protected]>
#1033) * Enable `BlockCtxU256Gadget` for `BASEFEE` opcode in `scroll` feature. * Fix to restrict `DIFFICULTY` execution state only for scroll (to avoid soundness).
* make error enum * remove non_exhaustive
* add feature switch * add missing * fix merge
* done * retry * seem done * fix * Temp to comment out `Cached assign at ...` log. * clean-codes --------- Co-authored-by: Steven Gu <[email protected]>
* refactor assign into sub-methods, more docs * fmt * fix: doc escape square braces * fix offset increment
…#1045) * Add `TxEip2930Gadget` to begin-tx to handle EIP-2930 in evm circuit. * Move `AccessList*` to the front of `BlockNumber` to fix tx-circuit tests. * Merge `CopyDataType` of access list to `AccessListAddresses` and `AccessListStorageKeys`. * Delete `is_eip1559_tx` function which should be better to add in the EIP-1559 PR. * Rename function `access_list_address_and_storage_key_sizes` to `access_list_size`. * Add `AccessListRLC` to tx-table. * Fix test. * Remove `AccessListGasCost`, and try to calculate it by `AccessListAddressesLen` and `AccessListStorageKeysLen` --------- Co-authored-by: Rohit Narurkar <[email protected]>
* init table16 with generic refactoring * update cargo * add required cfgs * add benchmarking * customable bench * fmt * config gates for sha256 circuit * complete sha256 circuit * induce SHA256 in bus mapping * better challenge spec * integrate sha256 circuit into super * readme (wip) * complete precompile and sha256 table * clippies * fmt * better tests * fix issues and better printing for circuit layout * refine and fix issues * fix digest in table16 * fix layout, clippy and fmt * complete sha256 table * fix rw * fix rlc on padding * clippy and fmt * more tests * test added * sha256: update row cost per block * update readme (wip) * lookup input len * enable sha256 * more tests cases * refactoring aux data * fmt * fix precompile call test * fix another callop test * + update bench to circuit-sha256, + update readme * fix vk issue, add more test * trivial fixs * move sha256 circuit into zkevm-circuits * purge unused sha256 dir * bump halo2 version * fix blank comment
* wip * enforce eth v2.0.7 * update links * clean up zktrie * fix keccak circuit * fix gadgets * fix bus-mapping * everything compiles now * compiles * compiles * clean up * update zktrie links * update dep for zktrie * Fix all dep/compliation issues in Sync ff 0.13 (#1056) * fix all dep issue * use updated misc-precompile * fix test issue * purge lock file by upgrading mpt-circuit * final update for dep of mpt-circuits * update deps * build? --------- Co-authored-by: Zhang Zhuo <[email protected]> * upgrade halo2; * build * Upgrade rust-toolchain to `nightly-2023-10-27` in CI. * Fix some byte values (u8) from `u128` to `u64` in `SAR`. * uncomment unit tests for aggregator * fix clippy * uncomment sig circuit and tx circuit * uncomment rlc gates unit tests * fix make doc * uncomment sig/ecc related code * minor fix * clippy * undo last clippy.. * disable some super circuit tests --------- Co-authored-by: Ho Vei <[email protected]> Co-authored-by: Ho <[email protected]> Co-authored-by: Zhang Zhuo <[email protected]> Co-authored-by: Steven Gu <[email protected]>
* check that chunk_idx increases by at least 1 on boundaries * Add range check for chunk_idx --------- Co-authored-by: Mason Liang <[email protected]> Co-authored-by: Rohit Narurkar <[email protected]>
* make use of fixed columns wherever possible * add column for boundary_count to remove summation over all rows * remove "-" to avoid confusion
Co-authored-by: Mason Liang <[email protected]> Co-authored-by: Rohit Narurkar <[email protected]>
…uits into feat/blob-4844-da
* Correct pow_of_rand assignment in evm_circuit * Correct typo * Add rpi_length_acc consistency for chunk_txbytes section for padding rows * pow_limit is set to max l2 tx bytes in a blob for pow_of_rand table --------- Co-authored-by: kunxian xia <[email protected]>
github-actions
bot
added
crate-bus-mapping
|
Apologies. Selected the wrong target branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the
chunk_txbytessection withinPICircuitand condenses the section into one row with a copy constraint forTxCircuitwhere the correctness of l2 tx bytes accumulation and final keccak hash is actually ascertained.pow_of_randfromPICircuit.PICircuit.Type of change