feat(skore): Better grouping in the help menu of the metrics accessor#2838
Draft
glemaitre wants to merge 1 commit into
Draft
feat(skore): Better grouping in the help menu of the metrics accessor#2838glemaitre wants to merge 1 commit into
glemaitre wants to merge 1 commit into
Conversation
Contributor
Contributor
Coverage Report for |
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 2157 | 5 💤 | 0 ❌ | 0 🔥 | 5m 17s ⏱️ |
Collaborator
Then we can show the added custom metrics in the help tree which would be really cool imo |
Collaborator
|
How does this close #2746? |
Member
Author
|
Because we are not going to remove the individual metrics but instead try to improve the documentation as an alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2746
This PR improves the help of the metrics accessor by grouping the registry management methods, the metrics to be called, and the displays in to sub groups.
For the moment, we are hard coding them but if the metrics are dynamically generated, we could easily leverage the registry to populate the the registry methods and the metrics.
My initial thought is to have the following design: