chore(deps-dev): bump to ESLint v9 #3081

csouchet · 2024-04-22T09:07:01Z

In ESLint v9, we must have only one configuration file.

Some dependencies don't support officially ESLint v9, but it works 😊

ℹ️ ESLint 8 has been EOL since October 5, 2024.
https://eslint.org/blog/2024/09/eslint-v8-eol-version-support/#eslint-v8.x-end-of-life-is-october-5%2C-2024

Need to support ESLint v9:

✅ typescript-eslint V8: https://typescript-eslint.io/blog/announcing-typescript-eslint-v8

❌ https://github.com/sindresorhus/eslint-plugin-unicorn (but supports flat config)

✅ eslint-plugin-playwright: https://github.com/playwright-community/eslint-plugin-playwright?tab=readme-ov-file#usage

✅ https://github.com/prettier/eslint-plugin-prettier: https://github.com/prettier/eslint-plugin-prettier?tab=readme-ov-file#configuration-new-eslintconfigjs

✅ https://github.com/prettier/eslint-config-prettier: https://github.com/prettier/eslint-plugin-prettier?tab=readme-ov-file#configuration-new-eslintconfigjs

❌ eslint-plugin-jest:

npm error Conflicting peer dependency: [email protected]  
npm error node\_modules/eslint  
npm error   peer eslint@"^8.56.0" from @typescript-eslint/[email protected]  
npm error   node\_modules/@typescript-eslint/eslint-plugin  
npm error     peerOptional @typescript-eslint/eslint-plugin@"^6.0.0 || ^7.0.0 || ^8.0.0" from [email protected]  
npm error     node\_modules/eslint-plugin-jest  
npm error       dev eslint-plugin-jest@"~28.8.3" from the root project

✅ eslint-plugin-jest-extended: https://github.com/jest-community/eslint-plugin-jest/blob/main/src/index.ts

✅ eslint-plugin-import: https://github.com/import-js/eslint-plugin-import?tab=readme-ov-file#config---flat-eslintconfigjs

❌ eslint-import-resolver-typescript:

✅ eslint-plugin-notice: https://github.com/nickdeis/eslint-plugin-notice?tab=readme-ov-file#flag-config

github-actions · 2024-10-08T09:39:07Z

🎊 PR Preview a9f24a5 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-3081.surge.sh

🕐 Build time: 0.01s

_{🤖 By surge-preview}

github-actions · 2024-10-08T09:39:16Z

🎊 PR Preview a9f24a5 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-3081.surge.sh

🕐 Build time: 0.01s

_{🤖 By surge-preview}

package.json

Bumps the lint group with 6 updates: | Package | From | To | | --- | --- | --- | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `7.4.0` | `7.6.0` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `7.4.0` | `7.6.0` | | [eslint](https://github.com/eslint/eslint) | `8.57.0` | `9.0.0` | | [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) | `27.9.0` | `28.2.0` | | [eslint-plugin-playwright](https://github.com/playwright-community/eslint-plugin-playwright) | `1.5.4` | `1.6.0` | | [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) | `51.0.1` | `52.0.0` | Updates `@typescript-eslint/eslint-plugin` from 7.4.0 to 7.6.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.6.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 7.4.0 to 7.6.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v7.6.0/packages/parser) Updates `eslint` from 8.57.0 to 9.0.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.0...v9.0.0) Updates `eslint-plugin-jest` from 27.9.0 to 28.2.0 - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v27.9.0...v28.2.0) Updates `eslint-plugin-playwright` from 1.5.4 to 1.6.0 - [Release notes](https://github.com/playwright-community/eslint-plugin-playwright/releases) - [Changelog](https://github.com/playwright-community/eslint-plugin-playwright/blob/main/CHANGELOG.md) - [Commits](playwright-community/eslint-plugin-playwright@v1.5.4...v1.6.0) Updates `eslint-plugin-unicorn` from 51.0.1 to 52.0.0 - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](sindresorhus/eslint-plugin-unicorn@v51.0.1...v52.0.0) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major dependency-group: lint - dependency-name: eslint-plugin-jest dependency-type: direct:development update-type: version-update:semver-major dependency-group: lint - dependency-name: eslint-plugin-playwright dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint - dependency-name: eslint-plugin-unicorn dependency-type: direct:development update-type: version-update:semver-major dependency-group: lint ... Signed-off-by: dependabot[bot] <[email protected]>

…oalescing operator

tbouffard · 2025-03-11T09:48:09Z

eslint.config.mjs

+import jestExtendedPlugin from 'eslint-plugin-jest-extended';
+import noticePlugin from 'eslint-plugin-notice';
+import playwright from 'eslint-plugin-playwright';
+import prettierRecommendedConfig from 'eslint-plugin-prettier/recommended';


thought: (for my future review) Check if this includes the usage of "eslint-config-prettier/flat" introduced in v10.1.1.
See https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#1011 and https://eslint.org/blog/2024/04/eslint-config-inspector/

sonarqubecloud · 2025-03-11T13:17:37Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

csouchet added the dependencies Pull requests that update a dependency (dev or runtime) label Apr 22, 2024

csouchet force-pushed the chore/eslint9 branch 2 times, most recently from 43d040b to 32284cc Compare April 22, 2024 10:26

csouchet force-pushed the chore/eslint9 branch from 32284cc to 230c27f Compare May 24, 2024 08:01

csouchet changed the title ~~chore(dev-deps): Bump to ESLint 9.1.0~~ chore(dev-deps): Bump to ESLint v9 May 24, 2024

tbouffard changed the title ~~chore(dev-deps): Bump to ESLint v9~~ chore(dev-deps): bump to ESLint v9 May 24, 2024

csouchet force-pushed the chore/eslint9 branch from 230c27f to 1c596eb Compare July 11, 2024 16:25

tbouffard changed the title ~~chore(dev-deps): bump to ESLint v9~~ chore(deps-dev): bump to ESLint v9 Aug 2, 2024

csouchet force-pushed the chore/eslint9 branch from 1c596eb to b390ca9 Compare October 8, 2024 09:38

tbouffard reviewed Oct 8, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

tbouffard reviewed Oct 8, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

csouchet force-pushed the chore/eslint9 branch from eff6143 to 1b689f1 Compare October 8, 2024 14:30

tbouffard added the skip CI e2e tests GitHub Actions do not run e2e tests (for Pull Requests) label Oct 21, 2024

csouchet force-pushed the chore/eslint9 branch 2 times, most recently from 91de37e to b61d045 Compare October 29, 2024 15:32

csouchet force-pushed the chore/eslint9 branch 2 times, most recently from 41d62b4 to 4a843ec Compare November 18, 2024 15:22

csouchet force-pushed the chore/eslint9 branch from 4a843ec to 644c7af Compare December 6, 2024 09:33

dependabot bot and others added 10 commits January 7, 2025 09:56

replace the old dependencies for typescript-eslint by the new

a0c4cd2

rename the eslint config file

f179b53

Migrate the plugin

cc0e70a

migrate parserOptions

53e3c82

migrate extends

84f470f

migrate overrides

8145241

migrate ignore

9976840

wip: fix conf

97dec41

bump dependencies for eslint

a58e0f8

csouchet and others added 2 commits January 17, 2025 11:20

Upgrade ECMA version to 2020 in ESLint to keep the usage of Nullish c…

8b1de4f

…oalescing operator

Merge branch 'master' into chore/eslint9

63e555c

csouchet marked this pull request as ready for review January 17, 2025 10:24

csouchet requested a review from tbouffard January 17, 2025 15:08

csouchet added 3 commits January 20, 2025 14:38

Merge remote-tracking branch 'origin/master' into chore/eslint9

075ced6

bump eslint and dependencies

5f9e89c

Merge remote-tracking branch 'origin/master' into chore/eslint9

c949630

csouchet force-pushed the chore/eslint9 branch from fe33d00 to c949630 Compare January 27, 2025 15:57

csouchet and others added 8 commits January 28, 2025 11:16

Merge branch 'master' into chore/eslint9

fd58585

Merge branch 'master' into chore/eslint9

62db97d

bump eslint dependency

9bf203f

Merge remote-tracking branch 'origin/master' into chore/eslint9

431c815

bump eslint dependencies

c2c74dd

Merge branch 'master' into chore/eslint9

ba412d4

bump eslint dependencies

aac82e4

fix lint

cedbcc8

tbouffard mentioned this pull request Feb 21, 2025

chore(deps-dev): bump to ESLint v9 process-analytics/bpmn-visualization-addons#375

Draft

csouchet marked this pull request as draft February 24, 2025 12:24

improve config

a7d8244

csouchet marked this pull request as ready for review February 24, 2025 12:30

csouchet added 3 commits March 10, 2025 10:17

Merge remote-tracking branch 'origin/master' into chore/eslint9

a7df48b

bump eslint dependencies

7b3e944

bump eslint dependencies

60b21e2

csouchet force-pushed the chore/eslint9 branch from ac8a367 to 60b21e2 Compare March 10, 2025 09:19

csouchet added 3 commits March 10, 2025 10:28

Merge remote-tracking branch 'origin/master' into chore/eslint9

fe7a875

Merge remote-tracking branch 'origin/master' into chore/eslint9

6ea7b45

bump eslint dependencies

29c2e63

tbouffard reviewed Mar 11, 2025

View reviewed changes

Merge remote-tracking branch 'origin/master' into chore/eslint9

a9f24a5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps-dev): bump to ESLint v9 #3081

chore(deps-dev): bump to ESLint v9 #3081

csouchet commented Apr 22, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

tbouffard Mar 11, 2025

sonarqubecloud bot commented Mar 11, 2025

chore(deps-dev): bump to ESLint v9 #3081

Are you sure you want to change the base?

chore(deps-dev): bump to ESLint v9 #3081

Conversation

csouchet commented Apr 22, 2024 • edited Loading

github-actions bot commented Oct 8, 2024 • edited Loading

github-actions bot commented Oct 8, 2024 • edited Loading

tbouffard Mar 11, 2025

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 11, 2025

Quality Gate passed

csouchet commented Apr 22, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading