Skip to content

Fix #2243 - AssetSize bar disappears when deleting an asset #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

lindapaiste
Copy link
Collaborator

Fixes #2243

Should be merged after #2187 because I used Redux Toolkit for this.

Changes:

  • Convert assets reducer to Redux Toolkit.
  • When deleting a file, decrement the totalSize by the size of that file.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste
Copy link
Collaborator Author

@raclim I think this bug is worth fixing. If we want to hold off on redux-toolkit than I can write a different fix using the existing reducer. Should I do that?

@raclim raclim added this to the MINOR Release for 2.10.0 milestone Nov 7, 2023
@raclim
Copy link
Collaborator

raclim commented Nov 7, 2023

@lindapaiste I think it would be great to get Redux Toolkit in! Would be down to have that in first and then this merged in!

Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done

@raclim raclim merged commit 0f5494c into processing:develop Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssetSize bar disappears when deleting an asset
3 participants