Skip to content

[#3434] Remove left padding on overlay close button #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

JoaoJoaoVF
Copy link
Contributor

Adjusted the CSS to remove the extra left padding on the close button. This ensures that the active box is centered around the 'X' when clicked.

  • Removed left padding value from the padding property
  • Verified alignment in both desktop and responsive view

Fixes #3434

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Adjusted the CSS to remove the extra left padding on the close button.
This ensures that the active box is centered around the 'X' when clicked.

- Removed left padding value from the padding property
- Verified alignment in both desktop and responsive view
Copy link

welcome bot commented Apr 6, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good to me, thanks for your work on this!

@raclim raclim merged commit 414dd00 into processing:develop Apr 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings Closing "X" active box misalignment
2 participants