Skip to content

[#3444] Add keyboard shortcut update functionality #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

karanBRAVO
Copy link

This PR adds the Edit button in keyboard shortcut modal, so that users can change the keyboard shortcuts.

Fixes #3444

Changes:

  • Add the edit button
  • creates the context to share keyMaps and updateKeyMaps function

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@karanBRAVO
Copy link
Author

Hello @raclim,
What are your suggestions and feedback? Let me know if there's any issue.

One more thing to say, this PR is not yet completed, I have to add the same thing for all shortcuts.
Screenshot 2025-04-11 002444

@raclim
Copy link
Collaborator

raclim commented Apr 10, 2025

Thanks for the update on this!

I shared my thoughts about the development for this issue in its thread. Ideally, a pull request should be complete before submission. Since it's not complete yet, could you mark this as a draft instead?

@karanBRAVO karanBRAVO force-pushed the feat/change-keymaps branch from a46fa6e to cbc82da Compare April 11, 2025 20:47
@karanBRAVO karanBRAVO marked this pull request as ready for review April 11, 2025 20:47
@karanBRAVO
Copy link
Author

Hello @raclim,
I have updated the PR, need your reviews :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the keyboard shortcuts based on user preferences
2 participants