Typescript Migration #22: client/modules/Preview
#3749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erificationTokenState
…alAuthServices enum
…useSyncFormTranslations to handle null formRef
…med export; update useSyncFormTranslations FormlikeType to take generic
…update to named export, update types
…odulesUser Pr05 Typescript Migration processing#21: `client/modules/User`
…_yarn/min-document-2.19.1 Bump min-document from 2.19.0 to 2.19.1
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.13.1 to 3.14.2. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.13.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…_yarn/js-yaml-3.14.2 Bump js-yaml from 3.13.1 to 3.14.2
We recently [released p5.js 2.1.2](https://github.com/processing/p5.js/releases/tag/v2.1.2)! This adds it to the version picker. I have verified that this pull request: * [x] has no linting errors (`npm run lint`) * [x] has no test errors (`npm run test`) * [x] is from a uniquely-named feature branch and is up to date with the `develop` branch. * [x] is descriptively named and links to an issue number, i.e. `Fixes processing#123`
Add p5.js 2.1.1
Switch to jsdelivr for p5.sound CDN
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.7.3 to 7.0.11. - [Release notes](https://github.com/nodemailer/nodemailer/releases) - [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md) - [Commits](nodemailer/nodemailer@v6.7.3...v7.0.11) --- updated-dependencies: - dependency-name: nodemailer dependency-version: 7.0.11 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…_yarn/nodemailer-7.0.11 build(deps): bump nodemailer from 6.7.3 to 7.0.11
Collaborator
|
Hi @NalinDalal can you merge the current version of |
Author
hmm, thanks for heads up, yes i have locally checked the type errors after that 
|
clairep94
reviewed
Jan 18, 2026
Collaborator
There was a problem hiding this comment.
I think your branch is still out-of- sync with the current version of develop, as this file has already been migrated, so this should not show up on the diff. Same with all the other files related to the user module
Could you take another look?
I noticed that you're making this PR from your fork's develop branch. I would recommend in the future doing the following:
- Regularly sync your fork's
developbranch with the Processingdevelopbranch - Branch off of your fork's
developbranch with a descriptive branch name (eg.ts_migrate_client_Preview) - Before tagging for PR reviews, please check that tests all pass, and that your PR is up-to-date with the latest version of
processing:develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issue-number
Changes:
migrated
client/modules/Previewto typescriptI have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123