Skip to content

Conversation

@khanniie
Copy link
Member

@khanniie khanniie commented Jan 9, 2026

Migrates editor theming CSS for Codemirror v6.

Updates class names to use the v6 classnames and adds a highlight plugin to codemirror so that it gives syntax class names that we can assign our own themed colors to.

I moved a lot of the themed code (_p5-contrast-codemirror-theme.scss, _p5-light-codemirror-theme.scss, _p5-dark-codemirror-theme.scss) into themify (variables.scss) for consistency.

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@release-com
Copy link

release-com bot commented Jan 9, 2026

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-bef0afdae1

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying a lot of this up, I think this looks good to me! :)

@raclim raclim merged commit f5c1710 into develop-codemirror-v6 Jan 13, 2026
4 checks passed
@raclim raclim deleted the cm6-themes-v2 branch January 13, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants