Skip to content

Add underline to asset links for accessibility#3973

Merged
ksen0 merged 2 commits into
processing:developfrom
VaibhavNarayann:fix-assets-underline
May 17, 2026
Merged

Add underline to asset links for accessibility#3973
ksen0 merged 2 commits into
processing:developfrom
VaibhavNarayann:fix-assets-underline

Conversation

@VaibhavNarayann
Copy link
Copy Markdown
Contributor

Fixes #3934

Description

This PR improves accessibility on the Assets page by ensuring hyperlinks are visually distinguishable beyond color differences, following WCAG accessibility guidelines.

Changes Made

  • Added underline text decoration for all hyperlinks in .asset-table__row
  • Increased underline thickness to 0.1em on hover

File Changed

client/styles/components/_asset-list.scss

QA Steps

  1. Run the editor locally
  2. Upload assets to create asset links
  3. Navigate to:
    http://localhost:8000/{username}/assets

Verify:

  • Links are underlined
  • Hovering over links increases underline thickness

@yugalkaushik
Copy link
Copy Markdown
Contributor

@VaibhavNarayann Thank you for the PR. Can you share the preview for the changes please.

@clairep94 clairep94 added the Contributor Follow-up Required Request for changes, or other follow up required. Please see PR comments thread. label Mar 7, 2026
@runningonsideprojects runningonsideprojects self-requested a review May 14, 2026 05:45
Copy link
Copy Markdown
Collaborator

@runningonsideprojects runningonsideprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VaibhavNarayann !

Are you still interested in working on this PR? If so, please provide a visual of the changes made per the PR criteria. Thank you!

@VaibhavNarayann
Copy link
Copy Markdown
Contributor Author

Hi @runningonsideprojects

Yes, here is the visual! As shown in the screenshot, links in the asset table are now underlined. Hover state also increases the underline thickness to 0.1em.

Thank you!

image

@VaibhavNarayann
Copy link
Copy Markdown
Contributor Author

Hi @yugalkaushik!

Apologies for the late response! I have added the visual preview of the changes above. Thank you for your patience!

Copy link
Copy Markdown
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksen0 LGTM, this PR can be merged.

@ksen0 ksen0 merged commit db8ff47 into processing:develop May 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contributor Follow-up Required Request for changes, or other follow up required. Please see PR comments thread.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Styling refactor for links on hover for Assets Page of Profile Section

5 participants