Skip to content

Fix: Exclude @swc/html from Vite dependencies to fix Windows dev issue #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

HritvikBhatia
Copy link
Contributor

resolves #723

This PR addresses the issue where running npm run dev on Windows fails due to @swc/html being incorrectly imported during development. The error occurs because .node files are not properly handled by Astro’s dev mode.

npm run dev now runs successfully on Windows.
npm run build works as expected.

@limzykenneth
Copy link
Member

@lukeplowden Can you have a try of this PR and let us know if it works for you as well?

@lukeplowden
Copy link
Collaborator

@lukeplowden Can you have a try of this PR and let us know if it works for you as well?

Can confirm I get no errors

@ksen0 ksen0 merged commit 07bc456 into processing:main Mar 17, 2025
4 checks passed
@HritvikBhatia HritvikBhatia deleted the fix-swc-html branch March 17, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled promise rejection when building on Windows
4 participants