Skip to content

Fixed scrollbar in example output frame #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"js-yaml": "^4.1.0",
"keyword-extractor": "^0.0.28",
"lodash": "^4.17.21",
"p5.js-website": "file:",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you leave out package and package-lock from the PR, like with git ignore please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

"preact": "^10.19.5",
"tailwindcss": "^3.4.1",
"typescript": "^5.3.3",
Expand Down
3 changes: 1 addition & 2 deletions src/components/CodeEmbed/frame.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,8 @@ export const CodeFrame = (props: CodeFrameProps) => {
sandbox="allow-scripts allow-popups allow-modals allow-forms allow-same-origin"
aria-label="Code Preview"
title="Code Preview"
height={props.height}
width={props.width}
loading={props.lazyLoad ? "lazy" : "eager"}
style={{width: "100%", height: "100%"}}
/>
</div>
);
Expand Down